Vscode: Expose diff editor border color
We need a theme color for the diff editor border between the two editors. Currently, the separation happens due to the shadow only... which a theme can define to be really nuanced...
joaomoreno
All 11 comments
@joaomoreno So do you think the border for diffs specifically should override any editor border configuration in the theme?
itamark
on 8 Jul 2018
No, I think it should be an independent theme color.
joaomoreno
on 9 Jul 2018
@joaomoreno Ah - got it. That makes sense. I'll take this today if that's okay.
itamark
on 9 Jul 2018
@itamark are you currently working on this? You are not listed as an assignee.
sa-adebayo
on 9 Jul 2018
@sa-adebayo I was going to work on it tonight. Only Microsoft/vscode team can add/edit assignees I believe.
Do you want to take this instead of me?
itamark
on 9 Jul 2018
We can't add collaborators as assignees. @itamark Looking forward for the PR!
joaomoreno
on 9 Jul 2018
Great thanks @joaomoreno
itamark
on 9 Jul 2018
Okay @joaomoreno - check out #53931
I used the same exact colors as the regular editor border for consistency.
itamark
on 10 Jul 2018
@itamark great, I can see that you have submitted a PR. Dropped a couple of comments there.
sa-adebayo
on 12 Jul 2018
Thanks @sa-adebayo - I pushed the wording corrections and changed the PR description. Your suggestion was so much clearer than my initial text! :-)
itamark
on 14 Jul 2018
@joaomoreno close, this seems to be in via diffEditor.border ?
bpasero
on 17 Sep 2018
Related issues
ryan-wong
路
3Comments
vsccarl
路
3Comments
trstringer
路
3Comments
DovydasNavickas
路
3Comments
NikosEfthias
路
3Comments
Most helpful comment
Okay @joaomoreno - check out #53931
I used the same exact colors as the regular editor border for consistency.