Vscode: Align SCM viewlet with ViewsViewlet

Created on 2 May 2018  路  5Comments  路  Source: microsoft/vscode

Currently, the SCM Viewlet and the Views Viewlet use separate implementations of the contributable views model. Additionally, SCM is a frankenstein of views: it manages part of its views and merges that with contributable views.

Suggestion:

  • [x] Use the ContributableViewsModel in ViewsViewlet - #48535
  • [x] Move SCM views to contributable views
  • [x] Have that the selection within the Source Control Providers view only toggles setVisible() in the ContributableViewsModel
  • [x] Remove knowledge about SCM in ViewsService
debt feature-request scm verification-needed verified
Source
picture joaomoreno

Most helpful comment

@bpasero

done

picture joaomoreno on 7 Mar 2019
🎉3

All 5 comments

@joaomoreno Adopted views model in ViewContainerViewlet aka ViewsViewlet. Since SCM Viewlet is not completely a ViewContainerViewlet and it has some unregistered views, I have to incorporate the knowledge of SCM viewlet in ViewsService to skip enablement/disablement. See - fc6c30ed3158d2e4b30d767e97635b984c9fd32c

sandy081 picture sandy081 on 6 Jun 2018
👍1

image

bpasero picture bpasero on 6 Dec 2018
😄2

@bpasero

done

joaomoreno picture joaomoreno on 7 Mar 2019
🎉3

@joaomoreno
nice

bpasero picture bpasero on 7 Mar 2019
😄1

@sandy081 Can you verify w/ code review?

joaomoreno picture joaomoreno on 26 Mar 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

VitorLuizC picture VitorLuizC  路  3Comments
trstringer picture trstringer  路  3Comments
villiv picture villiv  路  3Comments
mrkiley picture mrkiley  路  3Comments
sirius1024 picture sirius1024  路  3Comments