Vscode: Merge include/exclude search pattern inputs
Related to https://github.com/Microsoft/vscode/issues/45063
We should combine the include/exclude inputs in the search view. It's a waste of vertical space and I doubt that people use them heavily enough to justify two separate inputs. This also would match other editors.
roblourens
All 5 comments
Do we still even need the ... menu?
roblourens
on 13 Mar 2018
How am I supposed to search for exclusive data types while ignoring certain folders?
e.g.
include: .js
exclude: /someFolderWithUnrelatedFiles/
Abhijay
on 20 Mar 2018
I don't understand the problem, please open a new issue with more details.
roblourens
on 20 Mar 2018
I doubt that people use them heavily enough to justify two separate inputs. That statement is rather unjustified on its own.
The idea for the merged field is nice - but might as well be considered poor UI/ UX. 20-30 extra pixels doesn't do much.
If this is necessary, then I/we would like to have the option to use either 2 inputs or just 1 input field.
Reasons why are explained in this issue: https://github.com/Microsoft/vscode/issues/46315
Crazy-P
on 22 Mar 2018
Terrible idea. Please revert.
acls
on 6 Apr 2018
Related issues
villiv
路
3Comments
vsccarl
路
3Comments
sirius1024
路
3Comments
curtw
路
3Comments
omidgolparvar
路
3Comments
Most helpful comment
Terrible idea. Please revert.