Vscode: Git: why is "go to file" suddenly so prominent?

[bpasero]

I am not a big fan of the new action to open a file directly:

I am a very frequent user of the "Discard" change action and now I have to constantly aim at the right action to pick it. Before I knew my action was always the first action and now it is in the middle.

Can we back this by some numbers? How many people are really clicking there to open the file directly? Imho the action is way too prominent now and the workaround to use the context menu is easy enough:

Or directly from within the editor:

[joaomoreno]

I've actually been getting a lot of praise for that action... It was requested by a couple of users. Others have thanked me for it. Even @alexandrudima is a big fan.

We can have an option for it, but I'll leave it on by default.

[alexdima]

I think the usage varies from person to person. I oftentimes use the git viewlet unconsciously as a working set and I really like to quickly go to a file from there; I do a destructive operation (discard) far more rarely than a navigation operation (open file) in there.

One can argue the opposite, why is "discard" such a proeminent action to begin with, where we don't have top level actions on the file explorer to delete files (destructive operations).

I agree with @joaomoreno, something user-configurable is needed here...

[bpasero]

Sure a setting is fine, even though ugly because I am most likely the only user...

[bpasero]

@alexandrudima @joaomoreno how about a setting for what happens when you click on a change? the setting could state if the file should be opened or the diff (by default it would still open the diff).

[alexdima]

@bpasero My self-estimated usage of the git viewlet:

• top action by far: open diff editor on a file.
• second place: open the file for editing (not in a diff editor); sometimes I misclick and then do the editing in the diff editor because I'm lazy. Sometimes I switch from the editor title action. Sometimes I right click and look for open file.
• rest of the time: stage changes, discard changes, commit message, stage conflicts, etc.

So an option to toggle between open diff editor on a file and open the file would make my first and second picks exclusive to each other.

[ghiscoding]

Hi there, I don't want to disrupt a team discussion but I'm also a very big fan of this new "open file" button. I find the right+click too long to do and was quite happy to see this new button, which I use almost every day now. In fact my top actions are almost the same, if not identical, to @alexandrudima.

A setting for it is probably the best approach, these small new features are a huge difference in productivity.

[eamodio]

I have a love hate relationship with this feature -- I use it a lot, but only because there isn't another mechanism (I'd MUCH rather an alt-click or something on the item). I, like @bpasero, find myself having to be much more careful on targeting to hit the discard button (which I also use often).

[joaomoreno]

Added config.showInlineOpenFileAction setting.

[ghiscoding]

@joaomoreno I'm just curious, aren't we suppose to put the fastest condition, for performance reason, at the beginning of an if and the longest at the end? I mean, isn't your new config the fastest condition since it's in memory?

"when": "scmProvider == git && scmResourceGroup == merge && config.git.showInlineOpenFileAction",

Please disregard if it's not relevant, I was just curious. Thanks for the new flag

[joaomoreno]

@ghiscoding That actually depends on the implementation of the if. In this case, I do believe our context keys do yield as soon as a result is obvious. But all those values are in memory so it doesn't really make any difference in that regard. Checking the config is very likely to be the most expensive operation, though, since it probably needs a few more map hops to get to the answer.