Vscode: Focus integrated terminal on first startup

[usernamehw]

1. Have tab other than terminal active in panel
2. Reload the editor
3. Activate terminal tab
4. After the shell is loaded focus is not set

[Tyriar]

I can reproduce on mac

[bpceee]

Hi @Tyriar , I will create a PR to fix this, since it only needs a minor change..

[Tyriar]

A proper fix for this is a little tough, the reason is because we need to make sure that the panel is not focused when it shouldn't be (when launching VS Code, when showing but not focusing via the API). Also the reason the focus isn't happening is because of the async terminal initialization. It's also possible that this will go away once https://github.com/xtermjs/xterm.js/issues/955 is fixed.

[bialix]

"A proper fix for this is a little tough" - sorry but it worked well in older versions of VS code, but now is broken. Can you just revert those changes that introduces such bug?

[letmaik]

I can confirm that this worked before the terminal got replaced and it is the number one annoying thing now for me in VS Code.

[Tyriar]

There's a PR out for the toggling terminal portion of this which should land in either the March or April release.

[Tyriar]

@usernamehw fixed the toggle terminal case, the only remaining issue is clicking the terminal label on the panel (when no terminals are open).

[johnpapa]

thanks for the progress update @Tyriar