Vscode: Node v8.5.0 breaks the "uncaught exception" setting

[samrg472]

• VSCode Version: 1.17.0-insider (b0c0634)
• OS Version: MacOS 10.13 Beta (17A362a)
• Node Version: 8.5.0

Using the same sample code from #1746

function failingFunc() {
  return (undefined as any).nope();
}

let promise = new Promise((resolve, reject) => {
 resolve(failingFunc());
});

promise.then(v => {}).catch((e: Error) => {
  console.log(e.message);
});

"Uncaught exceptions" is disabled, however it keeps breaking, regardless if it checked or unchecked.

Reproduces without extensions: Yes

[samrg472]

I was able to confirm this in the stable version of VSCode as well. I checked whether node was the cause and it looks like it is. Switching to node v8.4.0 no longer has this issue.

[roblourens]

I can repro as well, with something as simple as

console.log('before');
Promise.reject(new Error('error'))

This is a Node bug, I filed https://github.com/nodejs/node/issues/15464

[roblourens]

You can workaround it in VS Code with

"skipFiles": [ "<node_internals>/**" ]

in your launch config

[MattMorgis]

The fix for this landed in be2a5b3 and will be released in Node v8.7.

The corresponding nodejs/#15464 is closed, so probably safe to close this too? Just wanted to help clean up 👍