Vscode: Search viewlet searching opened files regardless or include and exclude patterns

Created on 1 Aug 2017  路  11Comments  路  Source: microsoft/vscode

  • VSCode Version: Code - Insiders 1.15.0-insider (f39385b8326671dc6389f21f8c2e2f6afdb352a1, 2017-08-01T05:16:44.254Z)
  • OS Version: Windows_NT x64 10.0.14393
  • Extensions:

Extension|Author (truncated)|Version
---|---|---
git-project-manager|fel|1.3.2
seti-icons|qin|0.1.3

(1 theme extensions excluded)


Testing #31480

Searching https://github.com/sourcelair/xterm.js, notice that dist is excluded in settings, I have an explicit include setting, but because dist/xterm.js is opened (not active) search results are still presented.

image

bug search

Most helpful comment

For those who come across this thread like I did.
Double check that the cog icon is enabled like in the picture below. When disabled, the search mechanism disregards the settings and goes over all directories. Solved the problem for me.

All 11 comments

I did miss a case

This is also causing the results to look particularly confusing when there actually are results:

image

Notice that the other results are in ./src but it's not shown next to the files because there's an assumption that only 1 folder is showing.

I'm still seeing results from non-active opened files returned even though they are excluded by search.exclude:

screen shot 2017-08-04 at 11 53 01 am

@roblourens Are these the correct test steps?

Any way to promote this ticket out of the backlog? It's extremely annoying.

This is driving me insane! It renders search almost unusable... this should be a priority bug fix!

screen shot 2018-01-25 at 4 20 24 pm

Guys, can you please fix this? It searches within node_modules in my angular app even if I exclude it!!! You can imagine what a mess it shows as a result!

For those who come across this thread like I did.
Double check that the cog icon is enabled like in the picture below. When disabled, the search mechanism disregards the settings and goes over all directories. Solved the problem for me.

Same problem here with files excluded in .gitignore. The cog icon is checked (when unchecking it, I get far more results from log directory, so excluding from .gitignore partially works):

image

I've tried disabling Terraform plug-in with no effect. VSCode seems to like Terraform too much ;o)

When adding **/.terraform in search.exclude (my current workaround), I don't get results from this directory.

VSCode 1.31.1
Windows 10 1803

same problem if you just list directories to exclude in the exclude list below the search box. This bug should have higher priority. Search filtering is very important for navigating.

This is super frustrating.

**/distdid not work for me but dist/** did

Was this page helpful?
0 / 5 - 0 ratings