Vscode: JavaScript if block without brackets indentation

Created on 18 Jul 2017 · 38Comments · Source: microsoft/vscode

VSCode Version: Code 1.14.1 (2648980a697a4c8fb5777dcfb2ab110cec8a2f58, 2017-07-13T19:18:47.188Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions: none

Steps to Reproduce:

As of the 1.14 update, typing JS code has really annoying indentation behavior. I can't figure out why it changed and I can't find any relevant settings to try to change.

To reproduce, type this:

if (cnd) <enter> {

Expected result (pre-1.14):

if (cnd)
{

Observed result (1.14):

if (cnd)
    {

This is the worst indentation style!

bug editor editor-autoindent

Source

AshleyScirra

👍8

Most helpful comment

@mjbvz But that isn't the case at all. Here's what the original reported issue read as:

To reproduce, type this:

if (cnd) <enter> {

Expected result (pre-1.14):
if (cnd)
{
Observed result (1.14):
if (cnd)
   {

As explained in many subsequent comments, this is still an issue.

You happened to fix a related bug, just not the one described in this issue. Your fix gif shows that you type if (1) {} and then go back and hit enter between the if-condition and the braces. That is _not_ the flow that the bug describes.

ericdrobinson on 16 Aug 2017

👍3

All 38 comments

@mjbvz do you think our indentNextLinePattern is a little bit unnecessary for TypeScript/JavaScript ? It seams that this pattern is bothering ppl instead of helping them out most of the time as writing brackets around blocks is more common.

rebornix on 20 Jul 2017

I think enough libraries and developers do write single statement ifs that removing indentNextLinePattern entirely will be more annoying. Can we modify the regex to work around this?

mjbvz on 20 Jul 2017

@mjbvz I'm thinking about taking one step back on indentOnType. Usually the only time that indentOnType kicks in and helps you out is when the content matches decreaseIndentPattern. Maybe a workaround here is only adjust the indentation when it matches decreaseIndentPattern otherwise users decide what the indent level they want.

Right now I don't know how to make the regex aware of context in this case.

rebornix on 20 Jul 2017

Yes I think the expected behavior here would be to indent the next line only if there is no other content after the cursor. Would we be able to achieve that without indentNextLinePattern?

mjbvz on 20 Jul 2017

Expected behaviour should be same as pre 1.14, please.

simonl65 on 20 Jul 2017

I am having this exact same issue, but i can't find the indentNextLinePattern setting. Also its only happening if I have a project open, opening JavaScript files outside of a project it works fine.

supermoosefgc on 20 Jul 2017

👍1

Does anyone know what feature addition/change caused this to occur? I'm interested in understanding why this change came in as it impacts me every time I write control flow code (if, for, while, etc.). This has been a _constant_ source of frustration with TS/JS files since the 1.14 release (am currently on 1.14.2).

ericdrobinson on 27 Jul 2017

A temporary work-around is to downgrade to version 1.13.

anickle060193 on 29 Jul 2017

👎2

OK, I'm back - I don't have any setting with indentNextLinePattern - I'm now on 1.14.2

@rebornix Why can't the _feature_ that was added in 1.14 be removed - this is really annoying

simonl65 on 31 Jul 2017

👍2

@mjbvz you marked this as duplicate with #31272 and closed it, then you went and close #31272 and marked it as duplicate with this.
Most issues are pointing to this one as the real one.

davidstlyoui on 31 Jul 2017

@davidstlyoui This issue hasn't actually been closed. I think Github is just displaying the duplicate message incorrectly for this issue.

anickle060193 on 31 Jul 2017

indentNextLinePattern is an internal configuration name. There is no user setting to change it

@rebornix Have you had a chance to take another look into this issue?

mjbvz on 31 Jul 2017

@mjbvz Why have you closed this? I thought this was where we were tracking this issue (which is why 31272 and 30691 were closed)

simonl65 on 31 Jul 2017

@simonl65 It looks like he closed it as part of this commit. It looks like typing "Fixes [Issue #]" into the commit message will also _close_ that issue as part of the workflow. See this help page.

ericdrobinson on 31 Jul 2017

@simonl65 I closed this issue with a change that should resolve the problem. Please try it out in the next VS Code insiders builds

mjbvz on 31 Jul 2017

I just learned something! Thanks - I'll give that a try when vscode next updates.

simonl65 on 31 Jul 2017

Hmm, so I couldn't wait - I downloaded the insiders build (1.15.0-insider)!

Sorry to say - it's worse! I now get the following:

if(x)
    {

...that's four spaces before the { (1.14 only gave 2 spaces)

If it helps, my non-default settings are:

{
    "editor.insertSpaces": false,
    "editor.tabSize": 2,
    "workbench.sideBar.location": "left",
    "editor.wordWrapColumn": 82,
    "editor.renderIndentGuides": true,
    "editor.rulers": [
        82,
        120
    ],
    "window.zoomLevel": 0,
    "workbench.iconTheme": "vscode-great-icons",
    "workbench.colorTheme": "Visual Studio Dark",
    "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe"
}

This is a clean install of 1.15.0-insider - no extensions added.

What have I missed?

Question: Why can't the auto-indent stuff just revert to how things were in 1.13 - that worked fine?

simonl65 on 31 Jul 2017

@simonl65 This change just went in and is not yet in any build. You need to wait for the next nightly insiders build to pick up this change

mjbvz on 31 Jul 2017

@mjbvz Oops - over eager! Will try it tmz. Thanks for your efforts 👍

simonl65 on 31 Jul 2017

@mjbvz Sorry to say: it's not changed - still indenting the {.

BTW: Correct behavior in PHP - this affects JS & TS.

This is a real PITA

simonl65 on 6 Aug 2017

@simonl65 Please record a gif of exactly what you are seeing. Here's what I see:

aug-05-2017 17-13-17

mattbierner on 6 Aug 2017

@mjbvz Not sure how to ad a gif, so here are the steps:

Type if(1)
Hit enter
Cursor drops to next line but is indented (should be below the i of if
Type {
Type enter
Result is:

if(1)
  {
    |
  }

Expected result:

if(1)
{
  |
}

simonl65 on 6 Aug 2017

👍2

@mattbierner This is on the insiders build (1.16.0), I believe it's the same issue.
2017-08-11_08-27-11

TheCyberRonin on 11 Aug 2017

👍3

The original issue still reproduces in 1.15. It is not fixed!

AshleyScirra on 13 Aug 2017

indent-loco mov

watch me shift these lines down. ^. it expected that these lines _do not_ get indented on shift.

doh! is this the correct place for this report, @mjbvz, or shall i add my GIF elsewhere?

thx :)

cdaringe on 15 Aug 2017

@Rxswyers Yes. That is exactly the issue. It is truly frustrating.

ericdrobinson on 15 Aug 2017

@cdaringe I'm not sure that's the same issue - I guess you're using ALT + downArrow?

I don't get that in a javascript file either - which language mode are you in?

simonl65 on 16 Aug 2017

Can someone re-open this issue since it is not fixed? Otherwise I will probably file it again. It's really annoying.

AshleyScirra on 16 Aug 2017

@simonl65

ALT + downArrow?

yep!

I don't get that in a javascript file either

javascript language setting.

cdaringe on 16 Aug 2017

The original reported issue was fixed. I've opened #32653 to track to track the other case discussed in the comments

mjbvz on 16 Aug 2017

@mjbvz But that isn't the case at all. Here's what the original reported issue read as:

To reproduce, type this:

if (cnd) <enter> {

Expected result (pre-1.14):
if (cnd)
{
Observed result (1.14):
if (cnd)
   {

As explained in many subsequent comments, this is still an issue.

ericdrobinson on 16 Aug 2017

👍3

@mjbvz - the original issue I reported does still reproduce for me in 1.15 following the same steps. It's not fixed.

AshleyScirra on 17 Aug 2017

It's fixed in the insider release. Be patient for it to get to the stable build. @AshleyScirra

TheCyberRonin on 17 Aug 2017

🎉1 👍1

Yay - that fixed it! @mjbvz Thank you.

simonl65 on 17 Aug 2017

@mjbvz its still not fixed, just grabbed the latest version on a different fresh installed cmputer and this is still here. This is ridiculous.

azarus on 28 Aug 2017

@azarus I don't think the fix has made it to the release version yet. I'm guessing you're on version 1.15.x, but the fix is in 1.16.0-insider - which you can download from https://code.visualstudio.com/insiders

simonl65 on 28 Aug 2017

👍1

Awesome.

On 28 Aug 2017 21:21, "simonl65" notifications@github.com wrote:

@azarus https://github.com/azarus I don't think the fix has made it to
the release version yet. I'm guessing you're on version 1.15.x, but the fix
is in 1.16.0-insider - which you can download from
https://code.visualstudio.com/insiders

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/30933#issuecomment-325366937,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFlNcxMxLu9wF6vlKh-juUNjNSuRPji6ks5scszrgaJpZM4ObYuY
.