Vscode: [css] support grid layout properties
Need support for CSS3 grid layout in SCSS/CSS Linter
- VSCode Version: 1.12.2
- OS Version: Windows 10
artemirq
All 20 comments
@aeschli Can you point me to the place I need to add these properties?
Edit: https://github.com/Microsoft/vscode/blob/master/extensions/css/syntaxes/css.tmLanguage.json Do I need to repeat these steps to less and sass, too?
jens1o
on 19 Jun 2017
Any news about css grid layout support?
jimblue
on 5 Jul 2017
https://github.com/Microsoft/vscode-css-languageservice/blob/master/build/css-schema.xml would be the file to make the fix...
aeschli
on 5 Jul 2017
@jens1o , @aeschli - the grid properties already exist in the latest css-schema.xml. I think vscode just needs to use a bumped up version of the language service.
praveenpuglia
on 6 Jul 2017
Yeah, I wanted to write that now... Thanks for helping me :D
jens1o
on 6 Jul 2017
@praveenpuglia It's there but says browsers: none. We filter these properties. So please add the browsers that support it.
aeschli
on 7 Jul 2017
I see all the grid properties already have browser info available.
https://github.com/Microsoft/vscode-css-languageservice/blob/master/build/css-schema.xml#L3160
only grid-row-start has browsers set to none which i am now sending a PR for.
praveenpuglia
on 7 Jul 2017
aeschli
on 10 Jul 2017
vscode doesn't have the version of css-languageservice with that change
roblourens
on 1 Aug 2017
LOL , WTF? 馃挴
artemirq
on 1 Aug 2017
@roblourens yep! vscode needs a version bump in extensions. Also, a new version of the service has to be published to NPM
praveenpuglia
on 2 Aug 2017
YEAHHH in 1.15 this is finally fixed!
jens1o
on 3 Aug 2017
Seems to be fixed in .css files for 1.15 but not for .html files that have
Most helpful comment
Fixed by https://github.com/Microsoft/vscode-css-languageservice/issues/35