Testing: #27350
Steps to Reproduce:
Observe: scroll position is not restored
Not sure who owns this :-)
Extension editor uses Web view. Could be that, this was not adopted by the feature #22995 If it is scoped to all web views. @mjbvz FYI
I am also seeing this
Yes, the scroll preserving change only targeted htmlPreview and the release notes page this month. I'll port it to the extensionviews as well in June
@mjbvz hey you said you implemented this for the Release Notes tab for one month. Would it be possible to implement this for every release notes page?
I want to test the new features while reading about them and it's really annoying that the release notes tab always reloads when switching back to it - without a restored scroll position.
Nothing? :(
The problem is still present in Release Notes reader with 1.40.0 on Windows.
Still...
still present, in extensions & release notes
https://github.com/microsoft/vscode/issues/24122
https://github.com/microsoft/vscode/issues/58007
@mjbvz retainContextWhenHidden can solve that.
@moshfeu I wish it was that easy. I just tried adding retainContextWhenHidden: true at https://github.com/microsoft/vscode/blob/c26146d7c5a7b9b4b01e7b5d758fae087dea834a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts#L580-L582
But it didn't fix the problem. I also tried tryRestoreScrollPosition: true as the option name looked to be relevant. Didn't help either.
To prove I was changing the right place I temporarily switched enableFindWidget to false and verified that Ctrl+F no longer brought up the Find widget.
My guess is the ExtensionEditor gets completely reinitialized when I switch back to the tab after switching away.
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!
This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding
:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!
This is not a scroll position issue, VS code actively reloads WebViews when not in focus.
still present, in extensions & release notes24122
58007
Why would this comment be marked as spam? 馃 on the contrary it avoids spammy issues by linking similar issues? anyhow....
This is not a scroll position issue, VS code actively reloads WebViews when not in focus.
@okikio this is a scroll position issue though? it may be caused by WebView reloading, but the issue still remains that once you refocus, the scroll position should be maintained, so technically it falls within a "scroll position issue"...
still present, in extensions & release notes24122
58007
Why would this comment be marked as spam? 馃 on the contrary it avoids spammy issues by linking similar issues? anyhow....
This is not a scroll position issue, VS code actively reloads WebViews when not in focus.
@okikio this is a scroll position issue though? it may be caused by WebView reloading, but the issue still remains that once you refocus, the scroll position should be maintained, so technically it falls within a "scroll position issue"...
Fair enough.
Most helpful comment
:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!