Vscode: Theme: Sidebar default color foreground

[equinusocio]

• VSCode Version: 1.13.0-insiders
• OS Version: 10.12.14

The list default foreground color is hardcoded and not themeable. Ther is not the option to customise it:

[bpasero]

We seem to pick it up when you set foreground, but that might color too much.

[equinusocio]

The ipotetic list.foreground setting should not overwrite the sideBarTitle.foreground setting that set the color of the headings in the sidebar. Also the file path beside the file name i think should have his color setting, so we can achieve something similar:

@bpasero what do you think?

[equinusocio]

@bpasero there is a chance that this fix will be shipped with the next release?

[bpasero]

@equinusocio can you explain the scenario more? We find it a bit odd to introduce a generic list foreground color when you can actually not set a background color (unless for focus, selection). Instead, we have many places where the tree/list is being used where a background color can be set (e.g. sidebar, editor, panel). We think it would probably make more sense to introduce a sidebar.foreground and panel.foreground that then gets applied to the tree/list as well.

[equinusocio]

If i have a list with a 50% gray background (or any light color) in a dark theme the list default foreground color (white) will be not accessible, so i think we should have a way to change the list.foreground (we have list.hoverForeground why we can't have list.foreground? 😄 ).

If panel.foreground color affect only the tree list and not sidebar heading like in your previous screenshot there is no problems.

[bpasero]

@equinusocio how did you set the list to a 50% gray background, what color key did you use? Is this inside a panel?

[equinusocio]

@bpasero I mean any background, if a list is inside — eg. the sidebar — with a light background, in a dark theme, i can't set the list foreground color and i will have this result:

With "sideBar.background": "#cccccc"

We think it would probably make more sense to introduce a sidebar.foreground and panel.foreground that then gets applied to the tree/list as well.

I agree, a sidebar.foreground setting is more appropriate rather than list.foreground! :)

[bpasero]

Makes sense, that is my thinking as well 👍

[bpasero]

Added via sideBar.foreground.

[equinusocio]

@bpasero So sideBar.foreground can live with sideBarTitle.foregroundwithout overwrite it? Can i see the result? :)

[bpasero]

@equinusocio yes, sideBarTitle.foreground will always overwrite the value of sideBar.foreground, so you need to set both to get the right coloring.

However I think sideBarTitle.foreground should probably inherit the color of sideBar.foreground if it is defined. I can look into that.

[equinusocio]

@bpasero Thank you :)