Vscode: Polish affordance to maximize panel

[isidorn]

1. Add a default keybinding
2. Add an icon in the panel header

Currently there is only the action View: Toggle Maximized Panel in the command palette

[isidorn]

1. I am planning to add keybinding in the likes of cmd + k p, or cmd + k m, both of these are free but I hit this issue https://github.com/Microsoft/vscode/issues/22211
2. I plan to add an icon left of the close icon to all panels. Searched thorugh VS icons and I think we could use the following two (note that there are two states, so the icon would toggle)

These icons are currently in the VS style, I tried converting them to VS Code sytle icons but failed using @chryw utils methods here. The scripts ask me for input and output for which I give absolute paths on my mac but this produces no effect. What am I doing wrong here?

The downside of these icons is that the plus could be confused with the plus to add a terminal.
An alternative set of icons could be the win native ones to maximize / restore window position. However I could not find those in the Visual Studio icon repository

ping @bpasero @Tyriar @chrisdias @stevencl for feedback

[bpasero]

Sorry, but these icons do not imply to me a maximize/minimize behaviour at all. They look like icons used for trees to expand/collapse. Can we find something that is more typical, e.g. for window management where you have this typically:

[isidorn]

Yeah that idea I describe in my comment also in the last paragraph.
And I agree that solution would be the most intuitive, however could not find anything like that on the vscode icons site so we might need custom icons.

[stevencl]

Visual Studio uses the following when in maximised mode (minimise, restore to previous size, close)

And then these when not in maximised mode: (minimise, maximise, close)

I imagine that Christy could get these icons for us?

[bpasero]

Do we want all three, I wonder. We already have actions there and would probably end up with more than 3...

[isidorn]

We'll we do not want all three since minimize and close are the same in our context.

[bpasero]

Ah ok I was thinking that minimize would put the panel into the minimal height it can have instead of closing.

[Tyriar]

Don't use cmd+k p, the ctrl variant is copy active file path on Linux and Windows, which I use :smile:

{ "key": "ctrl+k p", "command": "workbench.action.files.copyPathOfActiveFile" }

The VS icons are a much better choice than -/+. Another option is to use a the old close button v for restore and invert it for maximise ^.

If we need I can write some SVGs in the style of the VS restore/maximise icon.

[isidorn]

I actually like the idea of using v and ^ in this case. Though I still feel like those original icons we used might be a bit too heavy and we could experiment with making them just a bit lighter

[chryw]

I like ^ and v for expand/collapse a panel that's on the bottom. I can make the icons. Just want to double check (sorry not a frequent VS Code user), is the panel always docked to bottom?

BTW @isidorn the path didn't work probably because I used a dirty quick workaround to turn "" into "/" for Windows' sake. You can get rid of the replace if you're already on unix environment.
gulp.src([${response.srcPath.replace('\\', '/') || 'src'}/**/*.svg]) -->
gulp.src([${response.srcPath || 'src'}/**/*.svg])

[Tyriar]

@chryw the panel is always docked to the bottom, however that may change in the coming months. If we did go with ^/v I expect we would rotate the icons 90° when the panel is vertical.

[isidorn]

@chryw I agree with @Tyriar point about possibly rotating. So let's go ahead and create those icons. Keep in mind that we previously already had a v icon, but it was too thick and did not fit well with the rest of the icons used in the title bar imho. So we could use something similar but I would prefer if it fits a bit better with the following

[chryw]

@isidorn
We have 2 sets of chevron icons. Do you think any of these works for the terminal panel?

945738_github_VSCodeTerminalExpandCollapse_Update1.zip

[Tyriar]

@chryw Maybe the second one's size with the first one's weight?

---

For reference here's a screenshot from an older version with the older icon:

[chryw]

Let's try these -
945738_github_VSCodeTerminalExpandCollapse_Update2.zip

[isidorn]

After discussing with @Tyriar we have agreed that no default keybinding is necessery especially since now the action is more visible.
@chryw thanks a lot for the icons, these work for me