Vscode: SCM icon needs love

[bpasero]

[joaomoreno]

I actually like it a LOT.

Btw renamed the issue. It's one icon for all SCM providers. Not a git specific one.

@bgashler1 What do you think?

[dfroze]

I have 2 problems about this:

1. if the button will be ONLY for git (even in the future), shouldn't it have the git icon or something 'Git' written ? The icon looks too similar to the Explorer button and its not intuitive to say 'hey, i am related to git'.
2. If it's for git, svn, etc, similar to the first question, it's not intuitive when looking at it, it's kinda similar to Explorer. Currently I sometimes mistake the current git button and extensions when they both have something new (one has updates, the other one has changes)

In conclusion, I think it needs more love :D
Edited: I've found something just show what I wanted to suggest http://www.larch.in/images/icon-qms.png

[bpasero]

It should at least align with the explorer icon.

[bgashler1]

I just put in a request to our icon team cc @chryw

[rmunn]

The http://www.larch.in/images/icon-qms.png icon looks like "upload to the cloud", which does not at all communicate "This is the icon for your source control system," at least to me. I'm :-1: on using a cloud icon.

:+1: for just using the Git icon. If Mercurial or SVN support is added in the future, then perhaps the icon could change to be the Mercurial icon when the current project folder has an .hg directory, or the SVN icon when the current project folder has an .svn directory. But defaulting to the Git icon makes the most sense.

[Krzysztof-Cieslak]

IMO, SCM extensions should be defining icon that is used there.

[Krzysztof-Cieslak]

And yes, I'd default to Git icon if there is no SCM initialized in current workspace.

[chryw]

I'm also in favor of defaulting to Git icon. But if you do need a generic version control icon, how about this

I really like @bpasero 's idea of using +- . I just changed the container so that it's less like the Explorer icon.

[dfroze]

Wonder if @chryw version could be used as default until setting up the version control tool. After setting it up, the icon can change to specific one or can remain the same based on the user preference. Some user might not like the idea, when working with multiple project each with different version control tool, to see different icon.

[chryw]

GenericVersionControlIcon.zip

Not sure where this landed. I'm attaching the icon file just in case.

[rhires]

Not thrilled w/ the new icon. How do we choose what icon goes there? Can I have one of the old ones back?

[joaomoreno]

We're just going to nail on one eventually, which some people will like and others won't. There are bigger things to worry about.

[rmunn]

But but but... I wanted the bikeshed to be blue! :grinning:

Seriously, though, "just pick one and move on" is the right decision. If enough people don't like it, submitting a new SVG icon in a pull request is always possible; if it gets several hundred upvotes, then I can't see the dev team saying "no" to merging it in. But they shouldn't spend their time re-painting the bikeshed every day.

And for what it's worth, I like the icon you picked as the default. Would I have picked something else? Sure. But eh, each VCS extension is going to change the icon anyway, right? So it's not worth spending time on the inevitable bikeshed.

[chryw]

btw I'm totally cool with this -

[joaomoreno]

@egamma isn't a big fan of the current one:

He suggested to experiment with the octicon one looks and prefers it:

@bpasero and @chrisdias Please let me know if you hate it.

PS: We are on the last week for this.

[bpasero]

I like our current one, the new one seems unbalanced.

[chrisdias]

I don't hate the new one, I like it better than the existing one (looks like a stethoscope to me).

Really though, I want to see the Git icon when i'm in a workspace that is backed by a git repository. Can an SCM extension contribute an icon?

[chryw]

Well we do have an equivalent version of that octicon. Just throwing it here.

GenericVersionControlIcon.zip

I think we all want a specified repo to show corresponding icon (git icon for git repo, etc.). This is only for "I don't know what type it is" scenario, isn't it?

[joaomoreno]

@chrisdias

Really though, I want to see the Git icon when i'm in a workspace that is backed by a git repository. Can an SCM extension contribute an icon?

We don't see a Go icon in the explorer when opening a Go workspace. Neither is the Java icon showing up in the debug viewlet when debugging a Java app. So why should SCM be any different?

[joaomoreno]

Went with the much improved repo-forked octicon: https://octicons.github.com/icon/repo-forked/

[chrisdias]

@joaomoreno perhaps after so many years i simply miss seeing the git icon there :(