Vscode: Closing tabs using mouse wheel click turns cursor into auto scroll

[efroim102]

• VSCode Version: 1.7.2
• OS Version: Windows 10

Steps to Reproduce:

1. Open multiple files at a time until the tab menu is scroll-able.
2. Click on an open tab using the mouse wheel, the tab will close, but the cursor will turn into auto scroll (css: all-scroll) and when you move the mouse it will scroll the tab menu.

When closing tabs using scroll wheel click, I shouldn't need to click away to get a normal cursor.

[bpasero]

I am not seeing this on my Windows 10 so I assume this is also mouse/configuration dependent.

[pawlikooo]

I have pretty same issue. I don't even need scroll-able tab container to reproduce it.

1. Open single file.
2. Click on an open tab using the mouse wheel.

Mouse cursor turn into 8-way arrows depends on its position.
Nothing scrolling on mouse move: neither tabs nor code.
Have to click middle mouse one more time to escape mouse scrolling mode.

Also it correspond to #12623

Version 1.12.0-insider
Commit 48ae6e3027be560d45dd1ebfbe090d6ff77af7f0
Date 2017-04-26T06:13:08.212Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0

[yume-chan]

This problem only happens when I set my DPI scale to 125%, all other values (100%, 150% and 175%) are ok.

Middle click at anywhere triggers scrolling, not only the tab bar.

I tried to add * { overflow: hidden !important; } but it doesn't help.

EDIT: Resizing the window sometimes makes the problem to disappear, and the problem may or may not appear again when resize again. Tried many times but can't find any relation with the window size/ratio.

[megakoresh]

Yes, very annoying. Happens all the time when window is maximized. When it isn't seems to work fine.

[bpasero]

Since I cannot reproduce this, I cannot help. If someone has ideas, here are instructions how to run VS Code from source: https://github.com/Microsoft/vscode/wiki/How-to-Contribute

[megakoresh]

It has been fixed in the latest stable release. I have not encountered this problem after the update.

[sleutho]

I'm running 1.17.2 on Windows 10 and still have this issue.
Even if I'd get a source sandbox running, I have no idea where I would even begin to diagnose this.

[bpasero]

Should have mentioned, all the tabs are being created and styled in tabsTitleControl.ts

[efroim102]

I have not encountered this issue for a while now, It must have been patched in one of the updates.

[jm-mwi]

As @yume-chan mentioned... I had my scaling set to 125%. I changed it to 100% scaling and the issue was alleviated.

I'm adjusting my font settings to look as I'd like, but it would be nice if this issue was fixed so that the middle click to close a tab worked regardless of if a monitor was scaled or not.

[bpasero]

@efroim102 @sleutho @megakoresh @yume-chan @pawlikooo can you verify that 125% scaling reproduces the issue and 100% scaling "fixes" it?

[megakoresh]

Yes, can confirm.

[pawlikooo]

Yes, just switched from 100% to 125% - still have annoying scroll mode. Turn back to 100% - it works fine.

Windows 10 Pro
VSCode 1.18.0-insider

[bpasero]

Can someone enlighten me how to get this scroll-with-middle-mouse feature to work? Is this a mouse setting?

[bpasero]

Actually I can reproduce...

[bpasero]

Looks like a return false from the mouse-down handler fixes it. The issue is that the tabs container is a scrollable element and middle mouse click should not start to scroll-lock with the mouse because this action is already taken by the close-tab behaviour.

[ostap1010]

It is still reproducible in version 1.18.1 on Windows 10. Really waiting for this fix.

[megakoresh]

It absolutely is, I think we will need to wait for next release for the fix to be merged.

[yume-chan]

@bpasero I finally have my problematic PC back, and I really don't want to say: the problem is still reproducible.

I'm using:

Version 1.19.0-insider
Commit 89b158e11cb1c3fe94a3876222478ed2d0549fc8
Date 2017-11-24T05:14:03.606Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

[bpasero]

Yeah I can still reproduce, weird. I pushed another change to call preventDefault() on the mouse event and that seems to help. We will have an insiders build tomorrow to give it a spin and verify.

[bpasero]

@yume-chan @megakoresh @ostap1010 can you give todays insider build a try to see if the issue is now fixed? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

[pawlikooo]

Checked on latest version few minutes ago with 125% scaling:

• Middle mouse click on tab works like a charm.
• Middle mouse click on empty space in tab bar still force scroll mode with zero reaction on moving mouse.
• Same with double middle mouse click (expected new "Untitled-1" tab).

Version 1.19.0-insider
Commit d88e71355feeb2b0deb02c021d33cb968531726e
Date 2017-11-28T05:13:37.597Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

[bpasero]

@pawlikooo yeah good catch, I addressed that via https://github.com/Microsoft/vscode/commit/d784938bc9b1b80f37bd30e505e626103a57f8b5