Vscode: "Disconnect" icon in toolbar is probably our most ugly icon

[bpasero]

Am I the only one that thinks this icon does not fit anywhere in our UI and especially not compared to the other icons in there?

[nerdybeast]

This made me literally laugh out loud because it's both true and funny :)

[isidorn]

I also fid the icon a bit ugly but I know that @weinand was showing some passion about the semantics of this one (square with a disconnect)
Getting a new icon is perfectly fine by me

[bpasero]

Imho there is too much detail in that little space.

[weinand]

I only started to show "passion" after a different icon for "Disconnect" (vs. "Terminate") got introduced. This new icon was looking completely different than "Terminate" and @bpasero complained about the icon looking "really bad".

Anyone interested in this issue should read #9740 and #10998 because we had this discussion already in August.

[bpasero]

Looking at the golden standard of debug UI (VS) I see the same icon being used for disconnecting from an attached debug session as well as stopping:

Even though there seems to be a "Detach All" action:

[weinand]

If we cannot design a convincing icon, then don't introduce one just for the sake of it. I don't think that there is a pressing need...

[isidorn]

Fine by me to just use the red stop square in both cases

[bgashler1]

We could ask the VS icon team to try making another icon, but I like what you guys are proposing to just use the same red-square icon and be consistent with VS IDE.

[weinand]

So then lets use the red-square icon for Disconnect too.

[fbnlsr]

Can't we use the Standby symbol which is universally recognized?

https://en.wikipedia.org/wiki/Power_symbol

[weinand]

I do not see how the Standby symbol helps in conveying the semantics of "Disconnect" (vs. "Terminate")?

[siegebell]

I like the idea of a plug in a red square. How about a less detailed plug?

[isidorn]

@siegebell I actually like this icon. Others?
@joaomoreno ping since I know you are passionate here.

[weinand]

@siegebell I like that icon!

[joaomoreno]

I don't really care about the icon. Just that it is different than stop.

[fbnlsr]

Just to itterate on @siegebell's idea, here's an icon with a complementary color based on the "refresh" icon that is currently in vs code. Definitely not perfect but it's an idea.

[isidorn]

Also not bad. Could somebody provide an SVG since all our icons in debug world are svgs?
Also for an svg I can easily change colors for different themes.

[siegebell]

Here's my source svg: vscode - disconnect icon.zip

[fbnlsr]

Here's an SVG of the icon I've proposed: https://drive.google.com/file/d/0B0hj0H1Hv6IibDFjclhPa183bUk/view?usp=sharing

[isidorn]

@fbnlsr that icon works for us. Can you please provide a PR that is simply adding this icon to the vs/workbench/parts/debug/browser/media
It would be great if you could do it in the next hour so we make it a part of the november release. We need a PR so you sign the CLA agreement

@siegebell also thanks for your svg but this one seems to be converted from a png so it has a much uglier svg form

[siegebell]

@isidorn did you not download the *.svg I attached? (The *.png is just a preview to put it in context)

[rkeithhill]

Did something happen with the Disconnect icon? In VSCode 1.8.0 the PowerShell extension (0.9.0) was showing this disconnect icon;

After I upgraded to 1.9.0 (and now 1.9.1), when I attach to a process using the PowerShell debugger, I see just the standard stop button. Bug or did someone change their mind on using a different icon for disconnect?

https://github.com/PowerShell/vscode-powershell/issues/486 cc @daviwil

[isidorn]

@rkeithhill no we still use it. If you have nice reproducable steps for how to get into powershell attach mode and the stop icon is showing please file a new issue in this repo and ping me on it.