Vscode: [themes] confusing alignment of file in folders in folder-less themes

[dylan-kerr]

The Seti icon theme released with VS Code 1.5 does not provide icons for folders (open or closed).

This causes a confusing misalignment between the names of folders and files at the same level of the hierarchy, making the files appear to be children of the last folder.

Would it be possible to enable folder icons with the Seti theme?

• VSCode Version: 1.5.1
• OS Version: Windows 10

[fhelwanger]

Here's a screenshot for reference:

It's very confusing to me. I keep trying to collapse the img folder, but it's already collapsed :confused:

[ramya-rao-a]

Same as @mdouglass's comment in another thread

https://github.com/Microsoft/vscode/issues/11705#issuecomment-245738458

[bpasero]

@aeschli let me know when you pushed the new CSS class for me to pick up.

[aeschli]

Think more about it I the css stylesheet rule does not help us.

• To find out if that css rule is defined, you need to iterate though all stylesheets and find it, or assign it to a DOM element and probe.
• you would have to have some kind of event listener that knows when a theme has changed

It's basically adds a coupling from the explorer to the theme service that we didn't had so far.
If we go that way I'd rather add real API (property and event) on the theme service.

Alternative is still that the theme service could style the tree.

[bpasero]

@aeschli yes you are right, needs more thinking. maybe you should just use a dummy folder icon that is transparent if a theme does not define one so that we get the same nice padding as all other icons?

[eamodio]

While I completely agree that the indenting can be confusing (and should be addressed), please don't add folder icons -- I love that Seti doesn't have them. Makes it much easier to scan for "important" things.

[greg-arroyo]

+1 for Minimal theme folder icon included in Seti theme.

• Combine the folders into the Seti theme as a wholly new theme (i.e.: Maximum) keeping existing themes
• Combine the folders into the Seti theme and provide the ability to turn on/off folders and icons (i.e.: editor.showThemeFolders, editor.showThemeFileIcons)?

Stoked for this recent update and getting rid of the constant updating of File Icons plugin.

[aeschli]

IMO a folder-less theme should work nicely as well and I want to fix that.
A folders on/off option is a good idea.

For all other requests, I'm sure the community will provide more themes, we don't need to cover it all with our built-in themes.

[dylan-kerr]

Although my original request did say "please add folder icons", it is really the indentation that's the issue. The existing open/close toggle is effectively a default folder icon, and I feel like it would make sense for the file icons to sit at the same place in the DOM (.content:before) to achieve the consistent indentation.

At the moment icon themes with a folder icon display both the open/close toggle and the folder icon - is this correct? They seem to be filling the same role.

[aeschli]

@dylan-kerr Yes, that correct. Good points!

[The-Smallest]

Hi,
For those, who still search for solution: there is "seti"-theme extended with folder icon in marketplace: qinjia.seti-icons

[octref]

This issue is not limited to Seti only:

I mistake buildfile.js as child of test every day, and I believe I'm not the only one.