Vscode: minimalEditOperations can break formattings

[jrieken]

Steps in https://github.com/OmniSharp/omnisharp-vscode/issues/660#issuecomment-244745885. Regression from 'fixing' https://github.com/Microsoft/vscode/issues/10133

[jrieken]

@egamma fyi

[DustinCampbell]

Thanks for digging into this @jrieken!

[nfantone]

@jrieken What about formatting not working at all (rather than messing with characters)? Are we talking about the same thing?

Taken from the original issue:

I work with Unity, but no matter if I open a whole solution or only a .cs file: the formatting of the code with (Shift+Alt+F), or by using the action in the command palette, isn't working.

[jrieken]

@nfantone Since I don't have reproducible steps for that it's guessing. However, no formatting can happen when the produced edits are really bad (overlapping etc). I am happy to dig further but I do need a repro.

Closing this issue which really was a regression from #10133

[DustinCampbell]

Why close this issue? Is it being tracked elsewhere?

[nfantone]

@jrieken Sorry for not following you on this: have you closed the issue because if was fixed by https://github.com/Microsoft/vscode/commit/ce1f925f1614dc5273f1813a6506eadd09575ed4?

And also, what do you mean by not having "reproducible steps"? For starters, you have a complete project uploaded here from where you can replicate the issue. But, nevertheless, if you would like to see the formatter in action, just create a new C# project and start playing around with the "Format Code" option. It'll take you no more than two minutes to realize that formatting C# scripts just does not work on VSCode. If you _really_ need them for some reason, you can certainly create your own steps - like I did in my previous comment.

[DustinCampbell]

@nfantone: based on the analysis in https://github.com/OmniSharp/omnisharp-vscode/issues/660, I was guessing that the bad edits were hitting some fail safe in the editor that caused it to start ignoring the command.

[nfantone]

@DustinCampbell All right. But which one is it? An analysis or a guess? Is this still happening on master? I tried updating Insiders to check it out but there's no new release, yet.

[DustinCampbell]

It's a guess based on incomplete analysis. :smile:

Once there's a new insider's build, we'll know more.

[nfantone]

@DustinCampbell @jrieken I'm happily reporting that after updating Insider, formatting now works again on all my Unity projects! Cheers for that.

One minor thing: I had to remap my formatting binding on MacOSX from Shift+Option+F to something else, because that combination kept adding a non-printable character instead.

[nfantone]

Now... if only there were a way of configuring format settings consistently across IDEs...

[johanneskopf]

@DustinCampbell @jrieken Same here - formatting is now working as expected on all my Unity projects on Windows 10.
Thanks for the fix!
I am now enjoying VS Code more than ever before.

[jrieken]

Thanks