Vscode: Feature Suggestion: Go to implementation

[RoarkeRandall]

• VSCode Version: 1.4.0
• OS Version: OS X 10.11.6

Steps to Reproduce:

1. Press f12 on a function that is an interface type.
2. Editor will go to declaration of the function on the interface, rather than the implementation (as expected).

In Visual Studio (with resharper) this is a nice feature.

[dvlsg]

This is actually available in Visual Studio 2015 Update 1 without resharper. I believe a default shortcut of Ctrl+F12 was added in Update 2.

[Tyriar]

This would be really handy to navigate vscode's source faster, currently I have to use view references and navigate to the implementation in the peek view.

[kkovalevskiy]

As I can see, tsserver has added support of this feature on their side (https://github.com/Microsoft/TypeScript/pull/10482), so why we still don't have it in vs code?

[Tyriar]

Thanks for pointing this out @kkovalevskiy! I've reassigned this and am very excited about the possibility of being able to use it soon 😉

[jrieken]

@Tyriar Taking this back because it shouldn't be a TypeScript only solution but implemented in the spirit of other language features, like go to definition, find referenced etc

[Tyriar]

:fireworks:

[jrieken]

@mjbvz I have reopened this because it takes aways the Find References keyboard shortcut

[jrieken]

Sorry, actually none-sense. I was confused with another extension I have

[unional]

Just tested and it is not working. It still routed to the declaration file.

UPDATE: didn't have time to create a repro yet. I'm trying to [Ctrl+F12] from an import statement of another package and landed on the declaration file.

[FredrikFolkesson]

I also have problems here, going to declaration on another package works and I get to the d.ts file, but going to implementation I only get "No implementation found"

[mjbvz]

@FredrikFolkesson Please open new issues for any problems related to go to implementation. Include a small project and a list of repo steps so that we can investigate

Thanks

[Wenzil]

Has a new issue been opened yet? The issue is still occurring.

Edit: I opened https://github.com/Microsoft/vscode/issues/26325

[3x1010]

Sorry if I post here but I'm getting mad about this topic.
I can't stand the fact that visual studio code is not able to jump to the definition in a case like this:

foo = funtion(){
this.init();
}

foo.prototype.init = function(){
// code
}

if I press F12, Alt F12, Ctrl F12, Shift F12, Ctrl F12 or whatever on "this.init()" Visual Studio Code is not able to jump to the foo.prototype.init method.

Where am I wrong? In Visual Studio 2015 this works, also it works on sublime.
Thanks in advance

[Tyriar]

@mjbvz is this just a limitation of tsserver that it doesn't check the prototype? Does VS2015 use some other system?

// this.init() go to def doesn't works
var foo = function() {
    this.init();
};
foo.prototype.init = function() {
    // code
};

// this.init() go to def works
class Foo {
    constructor() {
        this.init();
    }

    init() {
    }
}

[mjbvz]

VS2015 used a different JavaScript analysis engine, not one the from typescript that we use and that VS2017 uses. That engine could handle some cases better than we can, but also had some performance issue and to my knowledge was not being actively maintained.

However the case that @3x1010 provided looks like bug in TS. For the code:

function foo() {
    this.init();
}

foo.prototype.init = function () { /*...*/}

const a = new foo();
a.init()

Go to definition does work on a.init but not on this.init. I've opened https://github.com/Microsoft/TypeScript/issues/18171 to track this