I do not use Twitter, and so don't want to see the Tweet Feedback icon/smiley all the time. Add a setting to hide this, please.
While I love this feature, I think I can help with this one. :)
If we can agree on a behavior, I can land a PR for this. @bpasero What do you think?
I am not sure this scales (e.g. having an option for each and every thing in the status bar?). I would rather want to be able to e.g. right click on something in the status bar to hide it (like a Chrome extension) and then another way to bring things back to the status bar. This needs UX prep work too.
I know what you're saying. I like the way most browsers handle this, a drag and drop based toolbar. It works really well, and gives a way to personalize the status bar.
I'd really like to help with this. :)
go to /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.css
find .monaco-shell .statusbar-item>.dropdown.send-feedback{display:inline-block}
and change it to display:none
you'll likely need to do this after every update. Caveat: worked for me, but I take no responsibility for it breaking anything important.
It looks like the file has been moved. I edited this file (same change as above) to remove the icon: /Applications/Visual\ Studio\ Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.css
+1 Make it go away!
+1
pls, make an option to remove that annoying icon
tweaking editor's css is not an option
Would agree that we need an option for that.
Alternatively, is it possible that the Tweet Feedback button to be implemented as an extension instead? It kinda reminds me of Atom's metrics plugin, which is activated by default but can be removed.
+1
pls, make an option to remove that annoying icon
tweaking editor's css is not an option
+1
Also it should be possible to send feedback on the command palette by default.
Fix on (Arch) Linux is the same as above: the file is located at /opt/visual-studio-code/resources/app/out/vs/workbench/electron-browser/workbench.main.css
.
Has anyone looked into making an extension that can fix this? Perhaps something like this to inject custom CSS? https://github.com/be5invis/vscode-custom-css
On arch, installing an update reverts the css file. Having a setting (preferably) or an extension (okay-ish) would be better than manually editing on every release.
@leonadler well I guess the idiomatic Arch solution to that is to stick the following in /usr/share/libalpm/hooks/visual-studio-code.hook
to tweak the file after each package update:
[Trigger]
Operation = Install
Operation = Upgrade
Type = File
Target = opt/visual-studio-code/resources/app/out/vs/workbench/workbench.main.css
[Action]
Description = Removing smiles...
Exec = /bin/bash -c 'read -r f; sed -i 's/\.send-feedback{display:inline-block}/\.send-feedback{display:none}/' $f;'
When = PostTransaction
NeedsTargets
(This is a joke. Works for me though.)
+1
+1
+1
+1
+1
I neither want nor need social media integration in my code editor. It's obnoxious.
+1
I don't mind a way to provide feedback, but put it under the Help menu or something where you would expect to see something like this. It distracts me every time I look in the status bar for something... Sure we could edit the applications css file, but should we really have to?
Please use the "thumbs up" reaction on the issue itself to show your interest in it being resolved. If you write a "+1" comment, 22 people get a useless notification. (This goes for all GitHub projects, by the way.)
Thanks.
@bpasero @dbaeumer There is no one assigned to this now. I don't think that it makes sense to wait until someone rewrites large parts of the workbench UI. A lot of us OCD nerds are super annoyed by having a face staring at them that does not serve the user but only the marketing department. Do you really think that a grinning button to tweet about my text editor ought to be the most reachable and prominent permanent feature of the UI?
That said, VSCode is really, really lovely. Thank you for the work you put into it.
Screenshots in the release notes suggest that there might be an undocumented way of turning off the twitter smiley button (and that the VSCode devs are as annoyed as the users by it). Could you please let us in on the secret? Patching the CSS with every update is not a good solution.
Looking at it from a product design angle, there is absolutely zero reason for that smiley face to be where it is. It is distracting, it serves no function and given the target audience it at best annoys. It's probably a political decision, which is a shame because VSCode is an impressive product. It is the only Electron application I use because it doesn't feel like a web app and the only editor that was able to lure me away from Vim/Neovim for any extended period of time. Extensible code editors need to be customizable. Since hiding the element is a simple matter of adjusting the CSS, it should be a preference setting.
Interestingly enough, running the OSS version, this annoying marketing gimmick is missing but Marketplace does not work. Regarding @joschabach's observation, I guess for many screenshots the development version is used.
@herrbischoff I think you are right. Given all the thought and taste that went into designing the interface of VSCode, and reflecting on the needs and sensibilities of an audience of people that design software and user interfaces themselves, the smiley tweet feedback button sticks out like a sore thumb, and perhaps not just by accident. Everything about this UI element seems to be the decision of someone higher up in the corporate food chain with the power to overrule and vandalize the work of their hapless underlings. A hidden warning to engineers against working at MS?
Whilst the standard O365 suite apps (Excel, Word etc) all have a smiley face with a form, somehow Microsoft Teams got away with feedback light bulb which links to https://microsoftteams.uservoice.com. No twitter required.
I have updated the pacman hook in https://github.com/Microsoft/vscode/issues/7893#issuecomment-314497354 to reflect the current location of the CSS file so Arch users can automatically fix their editors. I am pleased to announce that this hook file is now in the Extended Support phase (Service Pack 2), meaning that I will occasionally check that the fix is still working and update it if I feel like it.
Regarding @joschabach's comments, perhaps what the smiley face really represents is a product-driven commitment to expanded consumer choice. For example, it made me aware of a product niche of editors without smiley faces, so I have now properly switched to spacemacs.
In addition to being able to hide the Feedback icon, why not settings to optionally hide any/all sections? I personally have no use for knowing that Spaces: 2
and that my line endings are LF
because those are the same for all of my projects.
Some simple toggle settings like these would be really nice:
"workbench.statusBar.showEndOfLineSequence": true,
"workbench.statusBar.showFeedbackSmiley": false,
"workbench.statusBar.showIndentation": true,
Just throwing this one-liner in here to get rid of it on macOS with a current path:
sed -i '' 's/\.send-feedback{display:inline-block}/\.send-feedback{display:none}/' /Applications/Visual\ Studio\ Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.css
^^ When I made that change & restarted the icon was gone, but then shortly after I got "Warn: Your Code installation appears to be corrupt. Please reinstall." :(
@pzelnip: It's a one-time warning and does not hurt anything. VSCode will continue to work fine.
VSCode updates frequently, and would have to be sanitized every time, which is not a good option. Is it feasible to fix it with a small extension (that could also customize the statusbar)?
A pattern we've been using lately is to allow hiding of components via the context menu, it would probably make sense to be consistent in the status bar:
(Copied this over from https://github.com/Microsoft/vscode/issues/3544)
May I ask what's the status on this?
A new setting workbench.statusBar.feedback.visible
was added to support this. This can also quickly be configured from a new checkbox in the feedback form itself:
...or from a new context menu:
Yay, thanks!On Jan 5, 2018, at 16:07, Benjamin Pasero notifications@github.com wrote:A new setting workbench.statusBar.feedback.visible was added to support this. This can also quickly be configured from a new checkbox in the feedback form itself:鈥擸ou are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
but the placeholder width is still there, can we guys remove that too? which should give us a correct align.
Not for me:
Maybe try a restart, it should be fine.
thanks, problem solved after disable the quokka extension
Most helpful comment
A new setting
workbench.statusBar.feedback.visible
was added to support this. This can also quickly be configured from a new checkbox in the feedback form itself:...or from a new context menu: