Vscode-yaml: Uses the wrong schema, even when yaml.schemas is set

[Xunnamius]

Describe the bug

I'm using this extension and the GitHub Actions YAML extension. The last three error messages (using the proper schema) are from that other extension. The erroneous errors above them are from this extension. Disabling the GitHub Actions extension makes those last three (correct, proper) errors disappear, leaving the false errors this extension is reporting.

The problem: this extension thinks my GitHub Actions workflow file is a "deploy php" file and so uses the wrong schema... simply because it has the word "deploy" in its file name. Change the name to build-test-deplox.yml and everything works. I can't make this extension ignore YAML files and I can't force this extension to use the correct schema (on the right, you can see the yaml.schemas setting being completely ignored).

Unfortunately for my .github/dependabot.yml file, I've had to disable this extension for now. Am I doing something wrong here?

Expected Behavior

Use https://json.schemastore.org/github-workflow for build-test-deploy.yml like I told it to

Current Behavior

Uses https://raw.githubusercontent.com/deployphp/deployer/master/src/schema.json instead

Steps to Reproduce

1. Have .github/workflows/build-test-deploy.yml file in your project
2. Observe this extension invoke the wrong schema
3. Try to override the schema for that file (using both full path and simple file name)
4. Observe this extension continue to invoke the wrong schema

Bonus: replace "https://json.schemastore.org/github-workflow" with "https://json.schemastore.org/github-workflowfdsfdsff"
in yaml.schemas and the extension recognizes that the schema does not exist, so it is receiving the proper schema from settings.json!

Environment

• [ ] Windows
• [ ] Mac
• [x] Linux
• [ ] other (please specify)

[gorkem]

Looks like it is related to https://github.com/redhat-developer/yaml-language-server/issues/250

[c00]

I'm experiencing the same issue. Slightly related, initially the plugin keeps guessing the wrong schema to apply. But then overwriting its guess with a setting as described in this issue does not work.

[cfbao]

Same issue with build_and_deploy.yml

Looks like it is related to redhat-developer/yaml-language-server#250

Want to highlight (from linked issue) that disabling schema store can work around this issue.

[badsyntax]

Having the same problem, with any github workflow file named '*deploy*'. I'm unable to set the schema with:

"yaml.schemas": {
  "https://json.schemastore.org/github-workflow": "/.githhub/workflows/**/*.yml"
}

[JPinkney]

It looks like "/.githhub/workflows/**/*.yml" is spelt wrong, it should probably be "/.github/workflows/**/*.yml". This issue is going to be fixed in the next release

[badsyntax]

@JPinkney good spot! Unfortunately it makes no difference, it's still using the deployphp schema.

[edit] good to know a fix is coming!

[Sytten]

FYI @JPinkney I still have issues for some templates

What is weird is that the descriptions are fine, but it still gives an error on the validation.

[libsamek]

I'm having a similar issue with GitLab CI configuration file, which contains deploy in its name. I have tried adding gitlab schema into yaml.schemas, but it makes no difference.

EDIT: It would be preferred if yaml.schemas would have higher priority than schema store.

[l3d00m]

This still seems to be happening on YAML 0.15.0.

VSCode about output

Version: 1.53.2
Commit: 622cb03f7e070a9670c94bae1a45d78d7181fbd4
Date: 2021-02-11T11:48:44.518Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.10.15-1-MANJARO

[l3d00m]

Interestingly enough, this issue only happens if the action is named deploy.yml. It works perfectly for deploy-dev.yml or my build actions.

[xsalazar]

I just ran into this same issue, and it definitely seems related to not only having deploy in the file name, but also position (maybe relative to symbol-separators?).

docker_deploy.yml

deploy.yml

deploy_docker.yml

[thadeu]

I solved problem by renaming file to deployer.yml

Thanks for help!

[joshriverscambia2019]

@evidolob with the fixed version of yaml-language-server installed, this issue is not resolved. Files named deploy.yml still get the incorrect schema match.

[evidolob]

Then we need to get https://github.com/redhat-developer/yaml-language-server/pull/427 merged to fix all issues with file match