Vscode-vsce: Readme.md: links to other sections in same page are lost in generated html

Created on 22 Aug 2016  路  12Comments  路  Source: microsoft/vscode-vsce

Given markdown:

[see below](#other-section)

Expected generated html (like on github)

<a href="#other-section">see below</a>

Actual generated html on the marketplace (hash part is lost)

<a href="">see below</a>

If the link is to another page however, then the hash part _is_ preserved

bug upstream

Most helpful comment

@eamodio this is now fixed on the Marketplace.

All 12 comments

cc @pradeepna

Confirmed in https://marketplace.visualstudio.com/items?itemName=lukehoban.Go, just inspect the link for Tools in the Using section. Seems like a regression.

ping @modigrv @pradeepna

Hi @joaomoreno, so what's the outlook on this one?
Would be really nice if internal links in readmes worked.

@joaomoreno Any update on this? It would be really great if these worked -- I have many links that provide a "link" between a feature and its settings.

See https://marketplace.visualstudio.com/items?itemName=eamodio.gitlens vs https://github.com/eamodio/vscode-gitlens/blob/master/README.md

I had thought that this was working at one point, but I could have been wrong.

@modigrv Any update here?

We are investigating and will get back

@eamodio thanks for bringing this up. We never supported links to other sections in same page on the marketplace site. We have a couple of customers requesting it now and we will put it in our backlog.

@kesane-msft thanks. I hope this is something that can be addressed sooner than later. Since the readme.md is being pulled into the vscode marketplace directly, I would think (and I certainly do think) that there is a strong expectation that something as basic as anchor-linking would be supported -- really all features in GitHub markdown honestly.

@eamodio this is now fixed on the Marketplace.

@kesane-msft THIS IS AWESOME -- thank you!

Though I did notice one "issue" while playing with it -- if you click on a link like eamodio.gitlens#user-content-extension-settings and then scroll around and click on another link that happens to also go to the same hash it won't re-scroll you to the right position.

@eamodio thanks for reporting the issue. We'll investigate and get back.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

brandoncc picture brandoncc  路  6Comments

vazexqi picture vazexqi  路  4Comments

kobelobster picture kobelobster  路  4Comments

equinusocio picture equinusocio  路  4Comments

SamVerschueren picture SamVerschueren  路  5Comments