Vscode-theme-onedark: Update due to the new semantic highlighting setting

[MohamadKh75]

Hey

As you can see in this issue, there is a new semanticHighlighting which breaks the theme and they asked theme maintainers to update the theme.

changelog

[akamud]

Thank you for bringing this to my attention. I'll release a new version fixing this issue.

[MohamadKh75]

Thanks!
It would be great if we can have https://github.com/akamud/vscode-theme-onedark/pull/95 in new release too 😁

[akamud]

Ok, it looks like this was not intended to be the default, so the next update (probably a 1.43.1) will disable this behavior and give us enough time to update our themes when we feel we are ready for the new tokenizations.

I see the code is in place already to disable this behavior as default, so we should just wait for an update and everything should come back to normal until I have the time to update with the enhancements. I can confirm this is the behavior in the insiders already.

In the meantime, as people already said, you should set this in your settings:

"editor.semanticHighlighting.enabled": false

I'm following the other issues not related to this.

[akamud]

95 is released in 2.2.0.

[AbdelrahmanHafez]

Is this fixed?

using Atom One Dark v2.2.0, VSCode v1.43.1, with

"editor.semanticHighlighting.enabled": false

Current colors:

As far as I can remember, object properties in JS had the same colors as the variable a in this example.

Am I missing something?

[akamud]

As I commented on #123, this is the new behavior in Atom as well. I give more details on how to bring back the old behavior and the reason behind this in the original issue.