Vscode-terraform: Provide an option to disable language server upgrade checks

[willhughes-au]

For the the last 10 hours or so, I've been getting repeated notifications to upgrade to 0.16.0
I'll switch windows, or lock/unlock my machine and again, there will be the prompt. Sometimes several of them.

"A new langauge server release is availale: 0.16.0. Install now?"

I don't want to install it.
I want it to shut up and stop bugging me. I've had to disable the extension just be able to get work done.

Yesterday it was fine, today something has changed and now it's an incessant pestering.

Please provide an option to either disable the upgrade checks entirely, or an option to suppress the prompts.

[radeksimko]

Hi @willhughes-au
There is an option to disable the LS in the command palette, have you tried it?

[glennsarti]

That seems like an over-reaction. Disabling the entire language server due to an update message?

https://github.com/hashicorp/vscode-terraform/pull/595

Honestly, I think it's a bug

https://github.com/hashicorp/vscode-terraform/blob/main/src/extension.ts#L169-L171

The code says every 24hrs, but the delay looks wrong.

Should be 1000 x 60 x 60 x 24
1000ms in a second
60 seconds in a minute
60 minutes in an hour
24 hours in a day

The current value of 1000 * 60 * 24 will check every 24 minutes

[rockdreamer]

I got three notifications for the same upgrade that would not go away. In the end, I had to kill the VSCode process tree. Not an over-reaction. It's quite suboptimal UX.

[aeschright]

I just put out a patch release that will bring those install attempts down to the intended once a day rate -- thanks to @glennsarti for doing the fix!

We don't have anything in the works right now for letting people skip an update until the next version, which sounds like it would be helpful for some of you. I'd be open to someone doing a PR on that, though, so let us know if you're interested.

[aeschright]

One other note: if you want to pin the language server to a particular release and keep the installer from checking for updates, you can install terraform-ls manually and set "pathToBinary" with the full executable path.

[glennsarti]

Not an over-reaction.

Sorry @rockdreamer I may not have said that correctly. I meant that it's bad that the workaround for too many update notifications is to turn off the entire language server.

[glennsarti]

@aeschright I may have a go at a PR to add a "disable update checks" setting. But I _think_ I can also see some problems with the current implementation which may trip some people up.

[glennsarti]

@aeschright PR is up.