Vscode-terraform: `tags = {` breaks syntax highlighting

[tresni]

Not sure if this belongs here or at hashicorp/terraform-ls, but the following block appears to break any subsequent stanzas:

resource "aws_instance" "test" {
  tags = {
    A = "thisisfine"
    B = "this is not fine"
    C = "neither.is.this"
  }
}

resource "aws_instance" "test2" {
    tags = {}
}

Expected result:

Proper syntax highlighting with "this is not fine" and "niether.is.this" being highlighted as strings and the next block being highlighted normally.

Actual Result:

Removing only B = or C = lines still gives a broken block, each of those lines appears to break the parser. Removing both lines and never having anything but [a-z0-9] in the tag value appears to be the only "fix".

[trotman23]

Adding some examples i've run into:

resource "example" "test" {
  test = [{
    key = "valu-e"
  }]
}

resource "example" "test" {
  test = [{
    key = "value"
  }]
}

resource "example" "test" {
  test = [{
    domain = "example.com"
  }]
}

resource "example" "test" {
  test = [{
    key = "value"
  }]
  key = "value"
}

[phil737]

What seems to break the highlighting is xxx = {
I have the same issue with for example:
config = {
path = ""
}

If I write
config {
}
it works.

tags {
}
works as well. But of course is not correct.

[StefanMihail]

I have the same issue on my end

[msgongora]

Just reverted to 2.1.1 because of this issue.
This is what I get:

[svb-cyberseceng]

We are also experiencing this issue

[giovannifl]

Some issue here when using vars:

[olegTarassov]

Same issue is observed on our end but using packer HCL2 where the syntax layout is broken due to the tag block.

example:

  tags = {
    Environment = "ECS Cluster"
    Team = "Platform"
    Approved = "no"
    Base_AMI_Name = "{{ .SourceAMIName }}"
    Base_AMI_ID = "{{ .SourceAMITags.TagName }}"
  }

Reverting back to version 2.1.1 fixes the issue and the layout is restored.

Thanks,

[mgabeler-lee-6rs]

Smells like a regression from #462 (meant to fix #442 which is distressingly similar to this issue)

[sc2pyro]

Also encountered this issue in 2.2.0 running in WSL; fixed by reverting to 2.1.1

[PaulDMendoza]

Yes, I had the same problem. I just had to roll back to 2.1.1 to resolve this.

[DenWin]

The problem can be drilled down to the equal sign in front of the curly bracket:

[DenWin]

Smells like a regression from #462 (meant to fix #442 which is distressingly similar to this issue)

Line 452 in terraform.tmGrammar.json to be precise. If one would revert this line back to 2.1.1 everything works fine!

[jufemaiz]

Ugh. v2.2.0 really wasn't well road tested.

As per above I've had to rollback to v2.1.1 as the latest release is completely unusable.

data "terraform_remote_state" "a_terraform_remote_state" {
  backend = "remote"

  config = {
    organization = "org_name"

    workspaces = {
      name = "how-sweet-are-workspace"
    }
  }
}

is but one example of things that broke syntax highlighting.

[ryderdain]

@jufemaiz thanks for the tip, for anyone else that needs to downgrade the v2.1.1 package is available via

curl -o /path/to/vsix/hashicorp.terraform.2.1.1.vsix https://hashicorp.gallery.vsassets.io/_apis/public/gallery/publisher/hashicorp/extension/terraform/2.1.1/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage

Then just uninstall the v2.2.0 version, restart, install the new package, restart VSCode again and works a charm.

[DenWin]

@ryderdain There is an easier method:

Just chose the version you wanna have.

[paultyng]

We are currently working on a fix for this, but for now the best option is to downgrade. We hope to have a hotfix out as soon as we resolve the issue.

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.