Vscode-spell-checker: Spawns too many "find" processes

Created on 3 Oct 2017  路  8Comments  路  Source: streetsidesoftware/vscode-spell-checker

I have no idea why but this extension spawns one find process per second in my environment.
image

Reproduced when disabling all other extensions, not reproduced when disabling this extension.

(Mac OS X 10.12.6, VSCode 1.16.1)

Done / Fixed bug

All 8 comments

Not sure if its related, but since today, vscode uses 100% of my cpu, unless I disable this extension.

(Win7 64bit, 1.16.1)

Any update on this issue? This is making the extension unusable.

Thank you. I'm pushing out a fix now.

That鈥檚 great, thanks for the quick turnaround- really appreciate all the work you put in on the extension- it鈥檚 really useful.

I was using a VS Code method to find the settings files. apparently it is VERY inefficient. It launches all the find commands.

I have turned off the code that searches for the local config.

Thanks!!

I was using a VS Code method to find the settings files. apparently it is VERY inefficient. It launches all the find commands.

Could you tell me which method it is? It might be vscode-side performance issue.

Could you tell me which method it is? It might be vscode-side performance issue.

Looking at his first commit for the fix, I assume the issue was with:

vscode.workspace.findFiles(findConfig, '{**/node_modules,**/.git}');

The original change went in to work around an issue with: workspace.createFileSystemWatcher(configFileWatcherGlob);
I was getting complaints about performance when someone opened vscode on a large project.

So, I switched to a polling method using workspace.findFiles. This proved to be even worse.

The final solution was to poll for the existence of explicit files and set watchers on them.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ili101 picture ili101  路  3Comments

ghost picture ghost  路  6Comments

gandalfsaxe picture gandalfsaxe  路  6Comments

blackwind picture blackwind  路  3Comments

xwang233 picture xwang233  路  4Comments