Vscode-rust: Formatting wrongly removes use statements (destructive formatting)
VSCodium 1.35.1
Rust 1.35.0
rls-vscode 0.6.1
The issue happens when formatting this project at this particular commit;
https://gitlab.com/schmilblick/violetear/web-client/commit/5052df6d39463da505737d8be21d63ca975331f9
Few use statements get wrongly stripped in src/main.rs
leo-lb
All 12 comments
I鈥榤 really confused why so few people run into this. This happens with pretty much every new use statement on stable and apparently beta and nightly too with RLS. It is a huge dealbreaker and very few people seem to complain about it. Is no one using RLS anymore or what?
CryZe
on 15 Jun 2019
https://github.com/rust-lang/rls-vscode/issues/576 contains quite a lot of affected users, but again, not everyone uses VSCode with RLS. It was working fine for a while, it only started doing this with some really specific code.
leo-lb
on 15 Jun 2019
As does #595 ... Seems like it is related to 1.35
feuerste
on 15 Jun 2019
Duplicate of #576
viktorku
on 16 Jun 2019
I can reproduce and confirm that it seems to be related to VSCode 1.35. Very annoying indeed.
AlisCode
on 24 Jun 2019
This has nothing to do with VSCode 1.35. This happened like 2 months ago or so too. It roughly started with the release of Rust 1.34.
CryZe
on 24 Jun 2019
This made its way to Rust 1.35 but the fix is in beta now and so this should land in stable Rust 1.36 release.
Xanewok
on 24 Jun 2019
Wait, there's a fix? Can you link that?
CryZe
on 24 Jun 2019
Xanewok
on 24 Jun 2019
Nice, I just tried Beta and it indeed seems to be fixed. Thanks so much :D
It almost feels like this should be in the release notes xD
CryZe
on 24 Jun 2019
Weird. In my case it really started happening with the latest VSCode but I guess it was just a coincidence of me updating everything at once.
Glad to see there's a fix :)
AlisCode
on 24 Jun 2019
Beta will be released in a week and so I'll close this issue if you don't mind. Thanks for reporting this! I'll pin https://github.com/rust-lang/rls-vscode/issues/576 to increase visibility of this issue and hopefully to reduce duplicate issues.
Xanewok
on 27 Jun 2019
Related issues
japert
路
4Comments
Tape-Worm
路
4Comments
iBeizsley
路
3Comments
alexreg
路
3Comments
simobiggs
路
4Comments
Most helpful comment
I鈥榤 really confused why so few people run into this. This happens with pretty much every new use statement on stable and apparently beta and nightly too with RLS. It is a huge dealbreaker and very few people seem to complain about it. Is no one using RLS anymore or what?