Vscode-remote-release: please use #!/usr/bin/env bash instead of /bin/bash (which often doesn't exist!)

[ghuntley]

Issue Type: Bug

https://twitter.com/GeoffreyHuntley/status/1124538617865523200

VS Code version: Code - Insiders 1.34.0-insider (473af338e1bd9ad4d9853933da1cd9d5d9e07dc9, 2019-05-01T00:22:05.899Z)
OS version: Windows_NT x64 10.0.17134
Fetching remote diagnostics for 'SSH' failed.

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (8 x 4200)|
|GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|63.92GB (51.76GB free)|
|Process Argv||
|Screen Reader|no|
|VM|33%|

Fetching remote diagnostics for 'SSH' failed.

Extensions: none

[anaisbetts]

Even better if it used login(1) somehow so that you got whatever shell you would normally get when SSH'ing in anyways

[roblourens]

In a terminal, you will get whatever shell you have configured. We just run our install script using bash. I can change it to find bash on the PATH.

[benpye]

@roblourens Is there a reason for the dependency on bash, would it be better to just use sh?

[roblourens]

That's probably doable. Is bash not available on your system?

[Reanmachine]

@roblourens Would this change effectively fix #33 by making the commands run in bash shell when a seperate shell is configured as the default?

[roblourens]

We already run the install script in bash regardless of the configured shell. The problem with fish is the very short bootstrapping script that invokes bash with the larger install script.

[anaisbetts]

@roblourens this doesn't seem to be the case for me, I'm always being dropped into a default bash prompt

[roblourens]

@tyriar Do users need to set the setting for their remote terminal or should it find the default shell?

@anaisbetts How do you set your default shell?

[Tyriar]

@roblourens the non-existing shell problem should be fixed by https://github.com/microsoft/vscode-remote-release/issues/38 as the default shell will be evaluated on the remote side (based on $SHELL).

[roblourens]

This is fixed in the new "nightly" build of the ssh extension, would appreciate people trying it to let me know if there's still an issue: https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-ssh-nightly (uninstall the stable version too)

Side note, had issues with flock when using just sh, keeping bash for now.