Vscode-pull-request-github: Changes in pull request: provide option to see changes as flat list

Created on 29 Sep 2020  路  5Comments  路  Source: microsoft/vscode-pull-request-github

Testing #2136

Similar to how the changes view in SCM can toggle between flat list and tree:

image

feature-request good first issue

Most helpful comment

Hi, I'd like to do my first contribution here, if someone could tell me where to look I'd really appreciate it. Thanks!

All 5 comments

There is currently a setting to do this (githubPullRequests.fileListLayout), we should an action to toggle it like in the SCM view

Hi, I'd like to do my first contribution here, if someone could tell me where to look I'd really appreciate it. Thanks!

Thanks @ejkim1996 for looking at this!

Two things need to be added for this:

  • A new command that will update the setting
  • An icon at the top of the "Changes in Pull Request" view that triggers this command

You can look at the commands.ts file for some examples of adding commands and add this one there as well. You will also need to add it in the package.json, and then add it to the view/title section there. pr.refreshChanges is an example of a command that shows up on the "Changes in Pull Request" view.

Thank you for the details @RMacfarlane!
I have quite a busy week at work, but I'll probably be able to get started on it sometime next week.

Hi @RMacfarlane,

I've been able to get the toggle to work! Here are some screenshots to show you how it looks.
Screen Shot 2020-10-26 at 11 16 22 PM
Screen Shot 2020-10-26 at 11 16 12 PM

I think the last thing that's left is to use icon(s) that resemble the file list layout. I couldn't figure out if there were already icons I could use so I've temporarily set it to the gear icon as you can see in the screenshots. I've also opened a draft PR, if you could take a look and suggest any other edits that are needed I'm happy to make the changes required.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

RamonMeffert picture RamonMeffert  路  3Comments

paulirish picture paulirish  路  3Comments

radu-matei picture radu-matei  路  3Comments

octogonz picture octogonz  路  3Comments

adrinjalali picture adrinjalali  路  4Comments