Vscode-pull-request-github: Review comments are duplicated

[meaghanlewis]

• Extension version: 1.79.0
• VSCode Version: 1.33.0
• OS: macOS

Steps to Reproduce:

1. Leave an inline review comment in the diff
2. Refresh the diff either by closing and re-opening or switching focus
3. Observe that all comments become duplicated

Discovered when testing for: https://github.com/Microsoft/vscode/issues/71103

[RMacfarlane]

I haven't been able to repro this yet - do you remember if you had the PR checked out when this happened?

https://github.com/Microsoft/vscode-pull-request-github/commit/87d575835f8dfdf40ddfb3029d6b341b32b4baa6 may have fixed this

[meaghanlewis]

@RMacfarlane i just tested this out again in 1.86.0 on the nightly build and am still getting the same problem. The issue does seem to only occur when the PR is checked out.

[RMacfarlane]

Thanks, I can repro it!

[meaghanlewis]

Thanks Rachel! 🎉

[RMacfarlane]

I'm using the 1.98 version of the extension and just ran into this again, so I'm reopening this issue.

[snoozbuster]

Still happening to me on version 0.7.0

[RMacfarlane]

This should be fixed as of version 0.9.0 as part of https://github.com/microsoft/vscode-pull-request-github/pull/1168, there was another case where a newly added comment wasn't being added to the cache correctly

[ivanvoznyakovsky]

it's back again 😞
Version: 1.39.0-insider
Commit: d157c2e941cae17acb79bf26a70bbfad732bdc83
Date: 2019-09-16T06:04:26.115Z
Electron: 6.0.9
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 18.7.0