Vscode-powershell: Powershell session not finishing - v2021.5.1

[baldieavenger]

Hey team,
Since the latest update, i'm not able to use the editor to run any code. Love that I wont get prompted to save now when running, not loving the fact the PowerShell session never completes now when running my auto loading profile (365 module signs in, which appear to be successful - Other than the latest ExchangeManagement module never popping out the creds prompt but I can work around using the lower version for now!)
All my modules pop up and sign ins are successful, but I cant figure out why the session hasn't finished to allow me to use the editor to run code now?
I've downgraded for now back to v2021.2.2 which lets me auto load my profile and sign in and let me carry on using the editor without issue.

[andschwa]

Hi,

Could you please provide more logging and environment information by following these steps?

Thanks!

[baldieavenger]

Hi,

Could you please provide more logging and environment information by following these steps?

Thanks!

Hiya!

Here you go, wasn't sure which so you have all 3!

I updated to v2021.5.1, restarted, entered creds from the prompts and tried to run something using F5 from the editor again and got the same issue.

Thanks!
VSCode-Logs-20210603..zip

[andschwa]

All three is perfect, thanks!

[andschwa]

Ah, I see in the logs that this is with PowerShell 5.1. Can you try PowerShell 7 and see if it still repros?

[baldieavenger]

I can, but, it's not managed Enterprise wide so this wont help for everyone here that uses Code as well as 5.1 on our prod servers. Also, embarrassingly im not sure how to update Code to use Ps7....
Is 5.1 no longer supported?

[baldieavenger]

Ignore this comment, it is still an issue with the latest VSCode, I just hadnt moved editors away from the settings page so didnt see the "Starting Powershell" notification not going away after everything has completed!

[baldieavenger]

Side note.... Now that im not prompted to save changes when using Editor, it doesnt run the code with the changes I made, unless I save it first. Is that intentional? I assumed it would allow me to run whatever was in that editor at that time, regardless of if id saved it or not?

[andschwa]

It should _only_ not be prompting for untitled files, and that should only be the case in VS Code Insiders right now. Otherwise that behavior is unchanged. What happened was that we added this default config for their upcoming feature: https://github.com/PowerShell/vscode-powershell/pull/3357/files

For PowerShell files, it is to set to prompt for nonUntitledEditorsInActiveGroup or, "all editors except those that are untitled."

[andschwa]

Sorry, haven't had a chance to look at the main part of this issue yet.

[baldieavenger]

No worries, I'm in the UK so the weekend has already started

[baldieavenger]

Happy Monday! Rearing to go to help out where I can for this!

[andschwa]

Hey! Sorry, I was on vacation this last week and am just now back today. I should get to this on Monday, currently just triaging everything.

[andschwa]

@baldieavenger I'm wondering if this has to do with the main PowerShell 5.1 bug https://github.com/PowerShell/vscode-powershell/issues/3395#issuecomment-859969488 that cropped up this release. Can you test this extension build? PowerShell-insiders.vsix.zip

[baldieavenger]

Hi Andrew,
I tried this but it didnt help. I thought it might just be me and my local, but my colleague now sees the same issue after updating to Powershell too so not just me!

[baldieavenger]

Hi Andrew,
Anything more you need from me to dig into this?
Thanks!
John

[baldieavenger]

Something to add! I use a little Microsoft.VSCode_profile.ps1 which contains a pop out then invoke command so I can choose the ps1 profile I want to use at the time and its this causing the issue!
If I just use my log in script as Microsoft.VSCode_profile.ps1 it auto loads, prompts, signs in and then has finished doing its thing!
If I use my function to open and let me choose which one, it doesnt!
Microsoft.VSCode_profile.txt

[andschwa]

Oh, that is helpful. I see your function uses System.Windows.Forms which I know is causing other issues too: https://github.com/PowerShell/vscode-powershell/issues/3410#issuecomment-860976636

[baldieavenger]

Looks like the same cause then for both of these too!
https://github.com/MicrosoftDocs/office-docs-powershell/issues/7895
https://github.com/PowerShell/vscode-powershell/issues/3396

[andschwa]

Ah, well, at least we know the problem. My understanding is that it may be difficult to fix due to the way System.Windows.Forms interoperates with a program's threading. But maybe https://github.com/PowerShell/PowerShellEditorServices/issues/1295 will fix it? We shall see...

[baldieavenger]

Thanks! Whilst I'm here...... Any ideas on another way I can open a dialogue box to ask me for a ps1 to load? Lol