Vscode-powershell: Remove Notebook API support

Created on 9 Feb 2021  路  4Comments  路  Source: PowerShell/vscode-powershell

The Notebook API support was partially implemented but based on early Visual Studio Code APIs which have yet to be finalized. Since our support is experimental, it probably ought to have been in a feature branch. So we're planning to:

  • [x] Turn off the GitHub actions which open new PRs updating our use of the experimental APIs
  • [x] Remove the Notebook code from the extension itself
  • [x] Save the prototype in a feature branch to be revisited in the future

/cc @TylerLeonhardt @rjmholt @SydneyhSmith

Area-Build & Release Area-Notebooks Issue-Meta Fixed

Most helpful comment

Yeah I think the key issue for us is that we had assumed the VSCode notebook APIs would stabilise sooner than it has, so it was acceptable to take the incremental changes in the meantime.

We've proven the concept (and helped VSCode develop their API), but managing the update PRs has become an ongoing burden — the simplest solution is for us to wait for the API to be exposed stably by VSCode and then to re-enable our notebook integration code.

All 4 comments

Yeah I think the key issue for us is that we had assumed the VSCode notebook APIs would stabilise sooner than it has, so it was acceptable to take the incremental changes in the meantime.

We've proven the concept (and helped VSCode develop their API), but managing the update PRs has become an ongoing burden — the simplest solution is for us to wait for the API to be exposed stably by VSCode and then to re-enable our notebook integration code.

That "feature branch" is just the fact that it's in the history as a merged PR 馃槄

Damn, I was just sitting down to finally play with this lol.

It'll come back one day! Just when the VS Code API is stable and we can integrate with it properly. For now, we're focussing on much-needed stabilization work for the extension. 馃槃

Was this page helpful?
0 / 5 - 0 ratings