Vscode-powershell: Powershell update button uses old brew install syntax that is deprecated

[philippkahr]

System Details

System Details Output

PS /Users/philipp> & {"### VSCode version: $(code -v)"; "`n### VSCode extensions:`n$(code --list-extensions --show-versions | Out-String)"; "`n### PSES version: $($pseditor.EditorServicesVersion)"; "`n### PowerShell version:`n$($PSVersionTable | Out-String)"}

### VSCode version: 1.52.1 ea3859d4ba2f3e577a159bc91e3074c5d85c0523 x64

### VSCode extensions:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]


### PSES version: 2.2.0.0

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      7.1.0
PSEdition                      Core
GitCommitId                    7.1.0
OS                             Darwin 20.2.0 Darwin Kernel Version 20.2.0: Wed Dec  2 20:39:59 PST 2020; root:xnu-7195.60.75~1/RELEASE_X86_64 (MacOS 11)
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Brew version

PS /Users/philipp> brew config

HOMEBREW_VERSION: 2.7.4
ORIGIN: https://github.com/Homebrew/brew
HEAD: 663b972f449b679512a2c0e3303569a2e9bfba7c
Last commit: 2 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 800e4b5fec9e6047fd0a1100500398cf85834247
Core tap last commit: 44 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.FaFo3wfVHI/org.macosforge.xquartz:0
HOMEBREW_MAKE_JOBS: 12
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby

Issue Description

I am experiencing a problem with the auto update toast notification. It uses the old brew upgrade cask powershell which is not supported anymore. Instead, it is brew upgrade --cask powershell.

Expected Behaviour

Use brew upgrade --cask powershell

Actual Behaviour

PS /Users/philipp> brew cask upgrade powershell
Error: Calling brew cask upgrade is disabled! Use brew upgrade [--cask] instead.

[SydneyhSmith]

@philippkahr thanks for opening the issue and the PR! We may want to update this install system in the future to not have to stay up to date with brew

[andschwa]

The fix for this was merged in #3132, not sure why the issue didn't close.