Vscode-powershell: Extension overwrites native colors of the theme

[PrzemyslawKlys]

Issue Description

So I updated to the newest version thinking it would solve the issue with theme colors being all green, and partially it did. But only partially. It's still green, just a bit less of it

This is native theme:

I get that there may be a difference between how theme highlights colors and how extension highlight colors but it should use theme colors, not just overwrite with predefined color set.

And to be honest it seems highlighting is better in theme, then by extension (ValueFromPipeline/Mandatory) gets additional highlighting. Same for $null.

Attached Logs

Follow the instructions in the README about
capturing and sending logs.

Environment Information

Visual Studio Code

| Name | Version |
| --- | --- |
| Operating System | Windows_NT x64 10.0.19042 |
| VSCode | 1.49.0|
| PowerShell Extension Version | 2020.9.0 |

PowerShell Information

|Name|Value|
|---|---|
|PSVersion|5.1.19041.1|
|PSEdition|Desktop|
|PSCompatibleVersions|1.0 2.0 3.0 4.0 5.0 5.1.19041.1|
|BuildVersion|10.0.19041.1|
|CLRVersion|4.0.30319.42000|
|WSManStackVersion|3.0|
|PSRemotingProtocolVersion|2.3|
|SerializationVersion|1.1.0.1|

Visual Studio Code Extensions

Visual Studio Code Extensions(Click to Expand)

|Extension|Author|Version|
|---|---|---|
|better-toml|bungcip|0.3.2|
|errorlens|usernamehw|3.2.1|
|github-linker|gimenete|0.2.3|
|gitlens|eamodio|10.2.2|
|line-endings|steditor|1.0.3|
|markdown-all-in-one|yzhang|3.3.0|
|material-icon-theme|PKief|4.3.0|
|open-in-browser|techer|2.0.0|
|powershell-preview|ms-vscode|2020.9.0|
|project-manager|alefragnani|11.3.0|
|rainbow-brackets|2gua|0.0.6|
|run-in-powershell|tobysmith568|1.1.0|
|swdc-vscode|softwaredotcom|2.3.11|
|vscode-markdownlint|DavidAnson|0.36.3|
|vscode-toggle-quotes|BriteSnow|0.3.3|
|vscode-wakatime|WakaTime|4.0.8|
|vscode-yaml|redhat|0.10.1|
|xml|DotJoshJohnson|2.5.1|

[SydneyhSmith]

Thanks @PrzemyslawKlys I think this brings up an important discussion around the priority between making things correct on the token level vs. making as many themes look good as possible.
In regards to the particular $null issue we can improve that, just have not had the time yet.

[PrzemyslawKlys]

Maybe an instruction on how to override colors would be sufficient. One could decide which colors to choose from. My main problem is I really dislike that green color and I lost the blue color that I like. For now I have disabled highlighting and use the theme way.

[TylerLeonhardt]

this was hinted at:

https://devblogs.microsoft.com/powershell/semantic-highlighting-in-the-powershell-preview-extension-for-visual-studio-code/#for-theme-authors-supporting-semantic-highlighting

you can probably do this in settings:

"editor.semanticTokenColorCustomizations": {
    "[Atom One Dark]": {
        "rules": {
            "type": "#FF0000"
        }
    }
}

[Pjmcnally]

Maybe an instruction on how to override colors would be sufficient. One could decide which colors to choose from. My main problem is I really dislike that green color and I lost the blue color that I like. For now I have disabled highlighting and use the theme way.

How did you disable the new highlighting? For now I have reverted back to the last stable version of the extension. However, if there is an easier way to disable the new highlighting I would prefer that.

[PrzemyslawKlys]

@Pjmcnally

    "editor.semanticHighlighting.enabled": false,

[Pjmcnally]

@Pjmcnally

    "editor.semanticHighlighting.enabled": false,

Thanks. I was overthinking that and digging into to the PowerShell extension settings instead of just the VSCode settings.

Also, in case anyone else runs across this if you want to disable semantic highlighting only for PowerShell you can do the following:

    "[powershell]": {
        "editor.semanticHighlighting.enabled": false
    },

[andschwa]

Related to #3221