Vscode-powershell: CodeLens References not working if function is in another file
System Details
System Details Output
### VSCode version: 1.41.1 26076a4de974ead31f97692a0d32f90d735645c0 x64
### VSCode extensions:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
### PSES version: 2.0.0.0
### PowerShell version:
Name Value
---- -----
PSVersion 7.0.0-rc.1
PSEdition Core
GitCommitId 7.0.0-rc.1
OS Microsoft Windows 10.0.18363
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0
Issue Description
CodeLens References does not work if the function is in another file. Both files shown below are in the same folder.
Note the 1 reference above the Y function definition. This is in the same file as the reference.
Note the 0 reference above the X function definition. This is in a different file to the referenc.
I wonder if this is related to: CodeLens References link only jumps to definition #2374.
Expected Behaviour
In TestModule.psm1 I expected to see 1 references above the X function definition.
Actual Behaviour
In TestModule.psm1 I see 0 references above the X function definition
Also Find All References for function X shows:
Find All References for function Y shows:
Attached Logs
PowerShell Extension Logs.txt
PowerShell Editor Services Log.txt
mrboring
All 27 comments
Nice find! I've fixed this and it will be available in the next version.
TylerLeonhardt
on 16 Jan 2020
Does this change cover the whole workspace? I have modules separated within multiple layers of folders and just got the same issue but with a bit diffferent thing.
It shows 0 references
Find References shows only 1 find in 1 file (the file the function is defined in) but clearly I have it in other files.
PrzemyslawKlys
on 17 Jan 2020
@TylerLeonhardt I'm also having problems with Go to Definition. I wonder if it could be related. If it's not, let me know and I'll create another issue.
Go to Definition not working.zip
In the attached zip there is a small test project.
Expected behaviour
Go to Definition should work for all functions.
Actual behaviour
PowerShell-Preview-2019.12.0.vsix
Go to Definition works for all functions.
PowerShell-Preview-2020.1.0.vsix
Go to Definition does work for:
- Test-FunctionLocal
- Test-FunctionAnotherDifferentFolder
Go to Definition does not work for:
- Test-FunctionDifferentFolder
mrboring
on 17 Jan 2020
Would you like to give it a try and see if it works for you?
PowerShell-insiders.vsix.zip
@PrzemyslawKlys, this also includes https://github.com/PowerShell/PowerShellEditorServices/pull/1162 so I'm curious how the PSIC looks for you.
Let me know if you have trouble installing. This is an unsigned build and has 0 official support so keep that in mind.
TylerLeonhardt
on 21 Jan 2020
Installing :-)
PrzemyslawKlys
on 21 Jan 2020
Won't run :)
PrzemyslawKlys
on 21 Jan 2020
@TylerLeonhardt I've installed the new VSIX and done a quick test. Both references and Go to Definition are working.
mrboring
on 21 Jan 2020
That's so weird that it works for you 👱♂️
PrzemyslawKlys
on 21 Jan 2020
@PrzemyslawKlys you've had trouble with dev build vsix's in the past IIRC
TylerLeonhardt
on 21 Jan 2020
oh wait - that's because I built on a mac and it has to be built on Windows. gah. give me a sec. Or just see if it works in PS Core - I don't have a Windows machine available right this second and Rob is on vacation.
TylerLeonhardt
on 21 Jan 2020
@PrzemyslawKlys Don't know if it helps, but this is my current configuration:
### VSCode version: 1.41.1 26076a4de974ead31f97692a0d32f90d735645c0 x64
### VSCode extensions:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
### PSES version: 2.0.0.0
### PowerShell version:
Name Value
---- -----
PSVersion 7.0.0-rc.2
PSEdition Core
GitCommitId 7.0.0-rc.2
OS Microsoft Windows 10.0.18363
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0
@TylerLeonhardt I'm on Windows 10 and it's working for me!
mrboring
on 21 Jan 2020
PowerShell 7, i tried on 5.1.
PrzemyslawKlys
on 21 Jan 2020
You also have both extensions enabled.... disable the primary one.
PrzemyslawKlys
on 21 Jan 2020
I can't build the part that's needed to get the extension working on 5.1 cause I use a mac. Only the part for PS6+. - for context.
TylerLeonhardt
on 21 Jan 2020
On PowerShell 7 seems to work. Thanx
PrzemyslawKlys
on 21 Jan 2020
You also have both extensions enabled.... disable the primary one.
@PrzemyslawKlys It was disabled. I've now removed it and it still works. As you've summised it works because I'm using PowerShell 7.
mrboring
on 21 Jan 2020
Yes, but I mean it only shows enabled extensions so it must have been "within the session".
PrzemyslawKlys
on 21 Jan 2020
@PrzemyslawKlys OK. I see. Thanks for the info.
mrboring
on 21 Jan 2020
Glad to here this issue is fixed :)
TylerLeonhardt
on 21 Jan 2020
@TylerLeonhardt I've done a bit more testing of the new VSIX and found a little issue.
The above is a screenshot of the project I attached above (https://github.com/PowerShell/vscode-powershell/issues/2421#issuecomment-576867256). Note that for the file: Test-FunctionDifferentFolder.ps1 that two entries appear. This file contains the definition of the function only. So, I would expect to only see one reference.
I also have a question. Would you expect Go to Definition to work across workspaces?
mrboring
on 23 Jan 2020
I've done a bit more testing of the new VSIX and found a little issue.
I'll look into this but please open a new issue so we don't lose this thread. And also attach the logs please :)
Would you expect Go to Definition to work across workspaces?
I believe there is some expectation that this should work. Right now, we are focused on closing gaps between the PowerShell Preview extension and PowerShell Stable extension. Can you try the Go to definition in the Stable extension to compare?
TylerLeonhardt
on 23 Jan 2020
Well I've opened this issue a while ago: https://github.com/PowerShell/vscode-powershell/issues/2112
It wasn't supported for multiple workspaces in the "old version'. But that would be cool if it would be possible. During development, I am often separating some code into different modules and it makes it much harder to debug things if only 1 workspace shows references.
PrzemyslawKlys
on 23 Jan 2020
I hear ya. There are a ton of opportunities for rich feature experiences for PowerShell in VS Code.
Unfortunately/fortunately, we had to focus on stability and performance for the past 2 years, peppering in small features as we go.
Plus there's really only 1 dev working on this at any given time so the resources are slim.
We're trying though. I hope that's visible.
TylerLeonhardt
on 23 Jan 2020
You don't have to tell me that :-) While I code only in PowerShell over my modules I get how hard some things are and that resources are slim. I have 40 PS modules that I manage mostly alone with some help from the community. I appreciate all the work you and your team do. I'll keep opening bugs/feature requests to make sure everything runs great. Even my F5 debug issue is no big deal now after you taught me how to "workaround" it - since I see what is happening now.
So take your time :-) I just wish there was a much faster process for preview between fix and release date so those small bugs like this one would go away faster than once per month. But as you explained, it's not an automated process so until that is done I'm fine :-) I automated my PowerShell modules building just so I don't have to spend time doing manual releases because I release modules daily, even multiple times per day.
PrzemyslawKlys
on 23 Jan 2020
@TylerLeonhardt As requested:
[2020.1.0 Preview] Find All References shows two entries for the function definition #2433
mrboring
on 23 Jan 2020
@TylerLeonhardt With regard to Go to Definition and workspaces, I've tried the latest stable and test versions of the extension. Both give the following message: No definition found for '<function name>'.
Looking at the comments on the issue created by @PrzemyslawKlys, it looks like this functionality has not yet been added.
mrboring
on 23 Jan 2020
Related issues
guidooliveira
·
3Comments
rkeithhill
·
3Comments
AWahlqvist
·
3Comments
rs38
·
4Comments
MiYanni
·
3Comments
Most helpful comment
You don't have to tell me that :-) While I code only in PowerShell over my modules I get how hard some things are and that resources are slim. I have 40 PS modules that I manage mostly alone with some help from the community. I appreciate all the work you and your team do. I'll keep opening bugs/feature requests to make sure everything runs great. Even my F5 debug issue is no big deal now after you taught me how to "workaround" it - since I see what is happening now.
So take your time :-) I just wish there was a much faster process for preview between fix and release date so those small bugs like this one would go away faster than once per month. But as you explained, it's not an automated process so until that is done I'm fine :-) I automated my PowerShell modules building just so I don't have to spend time doing manual releases because I release modules daily, even multiple times per day.