Vscode-powershell: Preview 2019.11.0/1 Read-Host paste dropping letters.

[ili101]

Issue Type: Bug

Same as in https://github.com/PowerShell/vscode-powershell/issues/1753 but only when pasting and sometime it misses random letters and not just the first one.

1. Copy something.
2. Run a file with Read-Host with F5.
3. Paste in console.
   

Extension version: 2019.11.1
VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:35:18.241Z)
OS version: Windows_NT x64 10.0.18362

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz (8 x 3392)|
|GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|15.93GB (6.52GB free)|
|Process Argv||
|Screen Reader|no|
|VM|67%|

[SydneyhSmith]

@ili101 thanks for opening this issue! We are able to reproduce this and are investigating what may be causing this.

[SydneyhSmith]

@ili101 we have published a fix for this, please let us know if you are still hitting this issue--thanks!

[ili101]

Still a problem on 2020.2.0 Preview

[TylerLeonhardt]

This doesn't repro on non-Windows. I'll have to try when I get into the office tomorrow.

@SeeminglyScience any thoughts?

[SeeminglyScience]

Maybe race condition here?

https://github.com/PowerShell/PowerShellEditorServices/blob/4c12d38a3f08d92c90846fa1dbb8a71495c4ad48/src/PowerShellEditorServices/Services/PowerShellContext/Console/WindowsConsoleOperations.cs#L35-L54

Maybe because the handle is released before the field is nulled?

Shot in the dark, if that doesn't pan out let me know and I'll take a closer look.

[TylerLeonhardt]

This only seems to affect the _first_ call to Read-Host and only when running with debugging (F5) for the first time in a session.

[SeeminglyScience]

Oh you know what, I bet the PSRL ReadKey thread isn't getting cancelled.

[TylerLeonhardt]

But wouldn't subsequent F5's have the same issue then?

[TylerLeonhardt]

Ok I've got a PR out for this!