Vscode-powershell: New temporary console debugging should probably not close until user presses key

[rkeithhill]

On 1.4.0 the new temporary console feature is nice but after the debug run is done, I usually want to sift through and inspect output. Perhaps we need a "Press any key to close the terminal"?

If the user presses F5 again to debug in a temp console, I'm fine if the extension forcibly closes the previous one.

[TylerLeonhardt]

Totally agree. This should be a thing.

[TylerLeonhardt]

This is a part of https://github.com/PowerShell/vscode-powershell/pull/1201 , right @rkeithhill?

[rkeithhill]

Yes, except that you don't press a key. You can close the terminal window using the little trashcan icon. Or you can let it hang around. The next temp integrated console debug session will close the previous session before it creates the new one.

[TylerLeonhardt]

Sounds good. We can probably close this then unless you think the "press a key" should be kept around.

[rkeithhill]

Fixed by PR #1201 and PSES PR https://github.com/PowerShell/PowerShellEditorServices/pull/625 in v1.6.0.

[mklement0]

@rkeithhill:

That's a great improvement, but it doesn't seem to have made it into v1.6.0, neither on Windows nor on macOS (haven't tried Linux).

Is there a problem with the PRs, or should we expect it in a future release and, if so, which one?

[rkeithhill]

There's a bug that has been fixed and will show up in the next release. It works today for the Pester Run/Debug Tests code lens. What it doesn't work for is launch configurations unless you specifically add the field "createTemporyIntegratedConsole": true.

[TylerLeonhardt]

We can probably release a 1.6.1 relatively soon to get that fix out.