Vscode-ng-language-service: Language service doesn't work at all: Cannot read property 'kind' of undefined

[tonivj5]

Describe the bug

Language service doesn't work at all. tsserverlibrary throws an error and extension never start. And consume a lot of CPU.

To Reproduce

Expected behavior

it works

Logs

Please attach two logs:

1. Console output (Go to toolbar --> View --> Output, and copy the contents)

[Info  - 14:29:20] Using @angular/language-service v9.1.9 from /home/yo/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js
[Info  - 14:29:20] Log file: /home/yo/.config/Code/logs/20200528T125828/exthost1/Angular.ng-template/nglangsvc.log
[Info  - 14:29:27] Enabling language service for /home/yo/Proyectos/my-project/apps/app/tsconfig.json.
/home/yo/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js:30390
                finally { if (e_1) throw e_1.error; }
                                   ^

TypeError: Cannot read property 'kind' of undefined
    at getConditionalFlowTypeOfType (/home/yo/Proyectos/my-project/node_modules/typescript/lib/tsserverlibrary.js:45510:28)
    at getTypeFromTypeNode (/home/yo/Proyectos/my-project/node_modules/typescript/lib/tsserverlibrary.js:47396:20)
    at getTypeOfNode (/home/yo/Proyectos/my-project/node_modules/typescript/lib/tsserverlibrary.js:67279:40)
    at Object.getTypeAtLocation (/home/yo/Proyectos/my-project/node_modules/typescript/lib/tsserverlibrary.js:35196:31)
    at getTsTypeFromBuiltinType (/home/yo/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js:28433:28)
    at TypeScriptSymbolQuery.getBuiltinType (/home/yo/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js:27600:28)
    at getEventDeclaration (/home/yo/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js:26668:30)
    at getExpressionScope (/home/yo/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js:26693:21)
    at ExpressionDiagnosticsVisitor.getExpressionScope (/home/yo/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js:26458:87)
    at ExpressionDiagnosticsVisitor.diagnoseExpression (/home/yo/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js:26775:30)
[Error - 14:29:29] Connection to server got closed. Server will not be restarted.

1. Log file (Path is printed to the console output at startup)
   Nothing anormal. Only initialization log.

Screenshots

Additional context

If I change this code:

to this code (&& node.parent):

It works like a charm.

I don't know if it's a problem from tsserver or ng language server

[tonivj5]

I have just see that @c0dybrown has commented about this issue here https://github.com/angular/vscode-ng-language-service/issues/793#issuecomment-635299761

[ayazhafiz]

What version of TS is being used? This should be in the output too.

[tonivj5]

You made me think, I have downgraded to 3.8.3 and it seems it works. I was using 3.9.3 :cry:

[ayazhafiz]

Yeah, please see https://github.com/angular/vscode-ng-language-service#versioning. Until the extension and the language service are on 3.9 it won’t work. But I think we can update to 3.9 now.

[ayazhafiz]

I spoke too soon, looks like 3.9 will be in Ng 10

[tonivj5]

Yeah, thanks for the hint. I also was too fast to upgrade to 3.9 :laughing:

If you think this issue should hold open for the future ng 10, cool, otherwise you can close it :sweat_smile:

[ayazhafiz]

TS updates happen automatically on our end :-)

Thanks for the report, closing as resolved.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}