Vscode-ng-language-service: Editor buffer out of sync with file on disk

[aditbharadwaj]

Describe the bug

The Angular Language Service server crashed 5 times in the last 3 minutes. The server will not be restarted. Even after restarting the Vscode the service keeps on crashing.

To Reproduce

Steps to reproduce the behavior:

1. Service Crashing after 5 minutes of working

Logs

1. Console Log
   output log of the vscode.txt
2. Log File
   nglangsvc.log

Screenshots

[ayazhafiz]

I think I know what is causing this, but I cannot reproduce the error. Are you able to show what you were editing when the crash happened?

[andrius-pra]

Could you try to remove "tslint-language-service" from your tsconfig.json?

[ayazhafiz]

@andrius-pra I loaded a project with 'tslint-language-service', and while the package could not be found, it didn't crash the language service. I could be wrong though.

There are two kinds of errors in the log. One of them is the result of a failed assertion during the editing of a source file (https://github.com/microsoft/TypeScript/blob/950b36192a10f5dac52993f1e29e62cbac513853/src/compiler/parser.ts#L8052). I think this may be caused by how we pass changes to source files: https://github.com/angular/vscode-ng-language-service/blob/fd3dfd92e67b57622955af09985e2d073c6cf336/server/src/session.ts#L233-L239

which changed since #553.

[andrius-pra]

@ayazhafiz, I have reproduced this issue.

[ayazhafiz]

Nice!

[aditbharadwaj]

I think I know what is causing this, but I cannot reproduce the error. Are you able to show what you were editing when the crash happened?

i was actually editing two files in split view and if u want the content i was basically calling variables and checking their definition. that's it. mainly it was whenever i was in split screens with multiple files it crashed for me.

[kyliau]

Thank you for the repro - this is caused by my recent PR https://github.com/angular/vscode-ng-language-service/pull/476
I don't remember why the change was needed to remove getExternalFiles(). I'll try to undo the change and fix this.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}