Vscode-ng-language-service: autocomplete on click should suggest (click)

[MingxunBai]

When i want to add (click) attribute with click, there is no suggestion:

However, it will suggest when beginning with (:

[iamcco]

It should also suggest *ngif when type ngi, with latest version I have to type *ngi

[ayazhafiz]

I think this was an intentional change with https://github.com/angular/angular/pull/34445.

[ayazhafiz]

cc @kyliau @andrius-pra @ivanwonder thoughts on supporting or closing this?

[kyliau]

I am in favor of the approach in https://github.com/angular/angular/pull/34445.
The main reason is because the suggestion list is _overly broad_ with the original implementation.
Take the following example:

<div |></div>

where | is the cursor position.
At this point, we are asking the editor, what are the possible candidates here?
The result is a long list of items (html properties/attributes/events with or without binding), and such long list hurts discoverability.

Since this issue was created before the autocomplete behavior was revamped, I suggest we continue the discussion in https://github.com/angular/vscode-ng-language-service/issues/521.

[andrius-pra]

I'm also prefer the current behavior. It's easier to write [, [( or ( character and choose relevant value from small list of suggestions that valid in your context.

[ivanwonder]

I'm also prefer the current behavior. It's easier to write [, [( or ( character and choose relevant value from small list of suggestions that valid in your context.

Agree.
and I think it's also good to provide bind-, on-, etc on <div |></div>.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}