Vscode-jupyter: Matplotlib plot cannot ignore Vscode theme in Python Interactive Window and button images not changed on theme swaps.

[vzhangCM]

Bug: Notebook Editor, Interactive Window, Python Editor cells

Steps to cause the bug to occur

1. change the Vscode theme to dark+
2. enable 'Python > Data Science: Ignore Vscode Theme'
3. restart Vscode
4. plot a figure via matplotlib in Python Interactive Window

Actual & Expected behavior

The figure is expected to ignore the dark theme and has white background.
But the actual background color is black in the latest version 2019.10.41019. No issue in version 2019.9.34911.

Your Jupyter and/or Python environment

Please provide as much info as you readily know

• Jupyter server running: Local | Remote | N/A
• Extension version: 20YY.MM.#####-xxx
• VS Code version: #.##
• Setting python.jediEnabled: true | false
• Python and/or Anaconda version: #.#.#
• OS: Windows | Mac | Linux (distro):
• Virtual environment: conda | venv | virtualenv | N/A | ...

Developer Tools Console Output

[rchiodo]

Hmm. Yeah looks like we aren't checking ignore during load of the jupyter server.

[teristam]

I also have the same problem. Is there a temporary fix for now?

[rchiodo]

Yes, you can force the matplot lib to use the white theme.

Either run a cell with this code in it:

matplotlib.rcParams.update(_VSCode_defaultMatplotlib_Params)

or put that code into this setting:

python.dataScience.runStartupCommands

__VSCode_defaultMatplotlib_Params_ is a hidden variable we create on startup with the default params for matplotlib. Since it defaults to the white background, setting the matplotlib params to this value will reset the plots.

[IanMatthewHuff]

Looks like the icons might be off in this situation as well. At least to me it looks like dark theme icons were being used on the light non-themed control.

Yeah, there is a larger issue at play. Icons / buttons also don't swap on theme changes light / dark.

[IanMatthewHuff]

Validation notes please check that on a swap from light to dark theme that images in the native editor and the interactive window change to correctly match the new theme. This was not working previously.

[IanMatthewHuff]

Second validation note (noticed more theme issues while testing) change the plot viewer to respect the new "themeMatplotlibPlots" setting.

[rchiodo]

Validated except for selection rectangle around the plots

[IanMatthewHuff]

Validation fixes here:
https://github.com/microsoft/vscode-python/pull/8224