Vscode-jupyter: Content is getting overlapped in notebook toolbar

[DonJayamanne]

The text on the right (remote url and kernel info) is not getting wrapped.

[greazer]

Probably the same, but just in case:

[rchiodo]

The first picture was on purpose as it didn't seem necessary for this release. The wrap to the next line was not however.

[DonJayamanne]

The wrap to the next line was not however.

Wasn't this identified and fixed in a separate issue?

[DavidKutu]

is this ok?

[rchiodo]

No I think it should slowly shrink over time. Wrapping to the next line seems off to me.

[IanMatthewHuff]

I'm not 100% sure what Rich was meaning by "shrink". But I think that I would have it all squish down until it uses the minimum space possible in one line like so:

Then if it gets any smaller you would just lose text starting from the right side.

[rchiodo]

That's pretty much what I meant, except it would lose text from the URI and then the kernel name at the same rate.

[DonJayamanne]

I think we should just use a style to hide overflow with .... If velow a certain width we can just hard code to display a content of ... or hide the icons all together. E.g. what if we don't have space to even display ... (I think just hide in that case).

To me a more bullet proof solution is to overflow the icons into an overflow menu where user would have to click ... that would display the collapsed items.

[DavidKutu]

How about this? The toolbar turns into 2 lines if there's no space.

The thing is, if stuff shrinks, its gonna be hard to click. And if we loose text from the status bar then eventually it becomes useless as the status is not visible. If we do this, everything stays visible and clickable.

[rchiodo]

I still think we can't have two lines. Maybe it minimizes down to just the icon at some point. Then the icon can be clicked to change.

[rchiodo]

@ronglums @jmew what do you guys think?

[DonJayamanne]

I still think we can't have two lines

I agree, we should just reduce the size or collapse completely (i.e. hide) instead of taking vertical room.

[jmew]

I like the overflow "..." menu idea for the icons, i think that design is intuitive and follows the practice of basic design principles.

[IanMatthewHuff]

Validated, no overlap anymore, but it does push down to two lines.