Vscode-jupyter: Font ligature setting is ignored in the output of Markdown cells

[dimitry-ishenko]

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

1. Change "edit.fontFamily" to a font that supports ligatures.
2. Enable font ligatures in the settings, eg: "editor.fontLigatures": true.
3. Create new Notebook.
4. Enter the following text in a Markdown cell and observe ligatured properly rendered in edit mode and in the output of the cell except for the code block:

NB: The code block also does not respect the font setting, which is covered in a separate issue microsoft/vscode-jupyter#1604.

1. Now, disable ligatures in the settings, eg: "editor.fontLigatures": false.
2. Observe lack of ligatures in edit mode (as expected), but ligatures are still rendered in the output:

Actual behavior

editor.fontLigatures setting is ignored in the output of Markdown cells.

Expected behavior

editor.fontLigatures setting is respected in the output of Markdown cells.

Your Jupyter and/or Python environment

_Please provide as much info as you readily know_

• Jupyter server running: N/A
• Extension version: v2020.4.76186
• VS Code version: 1.45 and 1.46
• Setting python.jediEnabled: false
• Python and/or Anaconda version: python 3.8.2 (no anacondas here)
• OS: Ubuntu 20.04 LTS
• Virtual environment: N/A

Developer Tools Console Output

:hankey:

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

[dimitry-ishenko]

Error messages are likewise rendered with ligatures:

Eg, float, misclassification and flat_loss_mask above.

[DavidKutu]

Thanks for the issue @dimitry-ishenko. We'll discuss this in our next triage.

[greazer]

This is the same problem as microsoft/vscode-jupyter#1604. So closing this one. It has to do with the markdown control we're using. If we change that (which we might) or fix it in the future, both of these bugs will be fixed.

[dimitry-ishenko]

Thank you @greazer