Vscode-js-debug: SkipFiles does not work in Chrome attach mode

[egorshulga]

Describe the bug
The same skipFiles configuration, which works in launch mode, does not work in attach mode.

To Reproduce

1. Create following configurations:

    {
      "name": "Chrome",
      "type": "pwa-chrome",
      "request": "launch",
      "url": "http://localhost:1234",
      "skipFiles": [
        "${workspaceRoot}/node_modules/**/*.js",
      ],
      "trace": true
    },
    {
      "type": "pwa-chrome",
      "request": "attach",
      "name": "Attach to Chrome",
      "port": 9222,
      "skipFiles": [
        "${workspaceRoot}/node_modules/**/*.js",
      ],
      "trace": true
    },

1. Run Attach to Chrome configuration.

Actual result: node_modules are not skipped

Expected result (as in launch Chrome configuration above)

Log File

From Attach to Chrome: https://drive.google.com/file/d/1x42XTf8bXffw8Mo_JzTQYrEAVWLHBEh1/view?usp=sharing

From launch Chrome: https://drive.google.com/file/d/1B3DawKmbpmzaypoOOx4PpavaO1TOcXUG/view?usp=sharing

VS Code Version: Version: 1.47.0 (system setup)
Commit: d5e9aa0227e057a60c82568bf31c04730dc15dcd
Date: 2020-07-09T08:02:06.629Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

[connor4312]

Good issue, thanks! Will look into this next week.

[jasonwilliams]

@egorshulga have you tried with ${workspaceFolder} instead of ${workspaceRoot} ?
or **/node_modules/**/*.js

[egorshulga]

With ${workspaceFolder} (does not work both ways)

Run Chrome (does not work)

Attach to Chrome (does not work either)

With **/node_modules/**/*.js (does not work both ways)

Run Chrome (does not work)

Attach to Chrome (does not work either)

Would it be helpful if I paste extension logs as well?

[connor4312]

I'll be looking at this today -- it looks like I'll be able to reproduce this locally easily enough, but I'll let you know if I need more info.

[connor4312]

@egorshulga does this happen in the nightly build? I'm wondering if you're hitting the same issue that Mike hit in https://github.com/microsoft/vscode/issues/102412#issuecomment-658301904

[egorshulga]

@connor4312 Yes, it works! That's so cool there is nothing to fix, as it has been already fixed :grin:
When we can expect for this fix to be released as stable?

[connor4312]

Good to hear!

Because that was a less common and relatively minor issue (+ also involving a refactoring which carries some danger) I do not intend to ship that in a June recovery release. So this won't go out to VS Code stable users until the July release, in early August. It will be on Insiders earlier, probably starting tomorrow.

[quantuminformation]

Any way to add this to all chrome instances? Normally I just open chrome debugger via open windows.