Vscode-jest: [style] Indentation problem with status indicator

Created on 18 Feb 2020  路  9Comments  路  Source: jest-community/vscode-jest

Is it possible to move the status indicator to above the test instead of having it prefixed? I don't like how it messes with the indentation.
Before when a dot was used as the indicator the indentation worked fine.

image

good first issue

Most helpful comment

PoC at my fork. PR later today

Screenshot from 2020-06-26 12-14-37

For now I will provide only one color version, without light and dark theme. Difference isn't stark and I'd like to develop more granular settings for this feature in the future: Icon styles and color configuration. It would make dark/light colors obsolete.

Details to come, let's finish one thing at a time :)

All 9 comments

Agreed, this is really hurting the readability of tests for me. The old design was totally fine.

I didn't see the old design, but I was coming here to suggest moving the check mark to the beginning of the line and not affecting indenting if possible.

I regularly run into this issue. This impacts my work in two main ways:
1) moving tests becomes harder as I often mess up where the start of the test is
2) my project lints correct spacing and indentation and I often try to fix the indentation of the tests despite there being only a visual issue with the plug-in, which then causes my linting to fail

those are all valid points, we could maybe try to move the indicators to the gutter? Should be a fun simple PR, the code is all in src/decorations.ts... anybody interested?

Might give it a try this weekend 馃

@wrslatz image in gutterIconPath should do the trick. Are you working on it, or perhaps I could contribute to this? :slightly_smiling_face:

@Tymek go for it 馃憤

@wrslatz image in gutterIconPath should do the trick. Are you working on it, or perhaps I could contribute to this? :slightly_smiling_face:

@Tymek Go for it!

PoC at my fork. PR later today

Screenshot from 2020-06-26 12-14-37

For now I will provide only one color version, without light and dark theme. Difference isn't stark and I'd like to develop more granular settings for this feature in the future: Icon styles and color configuration. It would make dark/light colors obsolete.

Details to come, let's finish one thing at a time :)

Was this page helpful?
0 / 5 - 0 ratings