Vscode-gitlens: Cannot type backslash after installing "Git lens"

[mdelapenya]

• GitLens Version: 3.4.5
• VSCode Version: 1.11.2
• OS Version: MacOS Sierra 10.12.3

Steps to Reproduce:

1. Install Git Lens
2. Open a file under a git repo
3. Type \ at any line

Expected behavior: \ is written
Actual behavior: \ is not written

[eamodio]

@mdelapenya I can't reproduce this, nor can I fathom how GitLens could effect this -- do you have some key configuration setup for \?

[mdelapenya]

No, but I uninstall the plugin and everything works as expected.

Let me grab the computer and send my plugins​ list

[eamodio]

Is there anything else special about you setup? Do you have any customize key commands for GitLens?

[mdelapenya]

No, I don't have any special key command.

The top header info message appears just hitting \ with GitLens enabled.

Here it is a capture of my plugins:

[eamodio]

@mdelapenya I'm really at a loss here. Do you have any special keyboard layout or app (like karabiner or something?)? And you definitely don't have any occurrences of gitlens in your keybindings.json file?

If you open the GitLens extension and switch to the Contributions "tab" do you see \ listed?

[mdelapenya]

Hey @eamodio, I'm sorry to say no to all, no keyboard layout here nor gitlens contribution 😢

[eamodio]

@mdelapenya hrm. I still have no clue how this could happen. Are you on a US keyboard layout? What other else is on your \ key? I'm actually on vacation this week so I won't really be able to do much more until next week. Maybe we can screen share or something

[mdelapenya]

I'm using Spanish keyboard.

Yeah, we can do that once you are back

Thanks!

[eamodio]

@mdelapenya can you take a screenshot of the command palette if you type GitLens into it (with an open editor for a file in a git repo). I want to see what vscode thinks the keybindings are since they should show up there. Can you also take a screenshot of the GitLens contributions page (in vscode) -- make sure to scroll down to the Commands section (that also will show the keybindings).

I'm not sure if it is related, but I've found these vscode issues that could be related:
https://github.com/Microsoft/vscode/issues/4084
https://github.com/Microsoft/vscode/issues/14984
https://github.com/Microsoft/vscode/issues/23386

[mdelapenya]

Hi Eric, here I attach the screenshots:

Command palette

Commands contributions

[eamodio]

@mdelapenya can you try the new beta here: v3.5.0-beta? You can find installation instructions here: Installing Beta Releases

I'm still very much at a loss to how this is happening, but there have been quite a lot of changes in the latest version and with any luck maybe it will help.

[mdelapenya]

Hey @eamodio, with 3.5.0-beta it works as expected!

Thank you very much for your work here :)

Closing...

[eamodio]

Excellent! Thank you for your patience!

[nuttmeister]

Same error with GitLens 8.0.2 using Swedish layout on mac. Trying to do backslash will just output the git search box. It's weird that the default keyboard layout for GitLens would override the default backslash binding for macs. ALT+SHIFT+7.

[eamodio]

Please open the GitLens settings (run GitLens: Open Settings from the command palette) and jump to Keyboard Shortcuts and change to either the chorded set or custom set.

In the next GitLens release, I am thinking about switching to the chorded set by default to avoid these issues

[jjabba]

@eamodio
I agree that overlapping shorthand-conflicts should be handled by visual studio code. But for me, as well as @nuttmeister it's taking precedence over regular character input (i.e. for the __ character on a Swedish keyboard layout. I'm guessing since this is not a shortcut, it's not detected as a conflict by visual studio code.

@nuttmeister My solution for now is to add these lines to keybindings.json:

{ "key": "shift+alt+7", "command": "-gitlens.showCommitSearch", "when": "gitlens:enabled" }

[eamodio]

Yeah, this has been a long standing issue and I will make the change to make the chorded set the default -- since it was "designed" to not conflict with any normal typing.

Yeah, you can definitely just remove any conflicting binding manually, or just switch GitLens to use a different keybinding set (or no set if you want to control it all manually)

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.