Vscode-gitlens: Cursor on Uncommitted message

[pankajpatel]

The cursor position should not be around the uncommitted info on empty line

[svipas]

I can confirm this, OS: Linux Ubuntu 16.04, VS Code: 1.10, Git: 2.11.0
Seems it was fixed, @pankajpatel can you confirm this after GitLens extension update?

[eamodio]

@pankajpatel as @svipben mentioned this should be fixed in a later version of GitLens. Please let me know if you are still seeing issues on the latest version (currently 2.9.0).

[pankajpatel]

Sorry for less info;

OS: macOS Sierra v10.12.3 (16D32)
VSCode: Version 1.10.1 (1.10.1)
GitLens: v2.9.0

Issue is still visible.

[svipas]

Right now I can confirm it too.

[eamodio]

@pankajpatel @svipben How do you get into that state? What are the steps?

[eamodio]

@pankajpatel @svipben fyi, I pushed an update with a set of fixes, some of which might address this -- please let me know if the issue still persists. Thanks!

[svipas]

I think I know why it happens, try to use tab or space in empty line, it will triggers Uncommited change.

[pankajpatel]

@svipben correct. And one thing that I noticed is that if the if the setting for rendering whitespace is ste to all i.e. "editor.renderWhitespace": "all" then the issue doesn't come up.

[eamodio]

@pankajpatel ah - that explains why I don't see it. Thanks for the information!

[eamodio]

@pankajpatel @svipben Thanks for all the information. This appears to be a vscode bug (as nothing I could think of had any effect at stopping this behavior). I've opened the following issues to track this: vscode #22018 & vscode #22017

[svipas]

@eamodio Thank you!
Off topic: can you show how Darwin OS looks like and from where I can download it? I found http://www.puredarwin.org website and I saw screenshots, so it looks like this? Seems old & ugly ;D
I'm using Elementary OS which is based on Ubuntu 16.04, but I like to try new things and I like macOS, which is why I prefer Elementary OS too look like mac :D

[eamodio]

np. Darwin OS is what macOS calls itself internally. I'm running macOS Sierra.

[eamodio]

Since vscode fixed this issue I'm closing it

[pankajpatel]

I also noticed the smooth working after updating the VSCode. Thankyou!

[pankajpatel]

This issue is reappearing again. can we reopen it?

[eamodio]

@pankajpatel you are still running the insiders build of vscode? If so is it the same scenario?

[pankajpatel]

I am sunning the stable version and the scenario was similar. It happens when there are spaces in the line.
VSCOde: Version 1.10.2 (1.10.2)
GitLens: 2.12.2

[svipas]

@pankajpatel it wasn't fixed on stable, it was fixed in insiders build as @eamodio said. I didn't tested, just waiting for stable release :smile: Try to download insiders build or wait for new stable release with fixes.

[eamodio]

@pankajpatel as @svipben mentioned the vscode fix will be in the next version (1.11) or the current insiders build.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.