Vscode-extension-for-zowe: Can't use Del key when renaming file in VS Code

Created on 6 Apr 2021  路  3Comments  路  Source: zowe/vscode-extension-for-zowe

Describe the bug


When renaming a file in the VS Code file explorer, pressing the Delete key doesn't work as expected, because Zowe Explorer intercepts the keypress and tries to delete jobs.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the VS Code file explorer pane (not the Zowe Explorer data sets pane)
  2. Right-click on a file and select "Rename"
  3. Press the Delete key while in edit mode
  4. See that the filename doesn't change, and occasionally an error message is shown

Expected behavior

Outside of the Zowe Explorer pane, Zowe Explorer should not affect the behavior of the Delete key in VS Code.

Screenshots


Attempting to rename a file:
image

Sometimes this error appears:
image

Desktop (please complete the following information):

  • OS: Windows 10 build 19042
  • Zowe Explorer Version: 1.13.1

Additional context


I believe the cause is this keybinding defined in package.json:

https://github.com/zowe/vscode-extension-for-zowe/blob/e721225315862326db53d8e7b270f2c38cb3b7dc/packages/zowe-explorer/package.json#L72-L76

The event filter "listSupportsMultiselect" seems to include the VS Code file explorer tree.

21PI2 bug

All 3 comments

@crawr Could this be resolved by just using the following when statement?:
"when": "view == zowe.jobs && listSupportsMultiselect"

@lauren-li I tried this one, but it didn't work for me. I also tried restricting it to just the context value but that didn't work either. :thinking:

@crawr I tried this one and it seems to work for me locally:
"when": "focusedView == zowe.jobs && listSupportsMultiselect"

Should I create a PR for this?

Was this page helpful?
0 / 5 - 0 ratings