Vscode-eslint: Just updated to 2.1.7 but I can't find anything about this release in the repo.

Created on 14 Jul 2020  路  5Comments  路  Source: microsoft/vscode-eslint

Just got a quasi-suspicious "user needs confirmation before executing code in local library" pop-up. So I went to see what the latest version's code is to verify it's legit. I cannot find anything about 2.1.7 in this repo. Can someone point me in the right direction?

image

From: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
image

@dbaeumer

Most helpful comment

Please add an option to disable the prompts. Adding them is a significant change that I would not have expected on a patch release. And there is no mention in the release notes of an option allowing us to disable the prompts to restore the old behavior.

image

All 5 comments

Will be merged in soon.

What if I have multiple projects in the workspace that all have their own eslint installations?

projects/
  projectA/ # eslint installed here
  projectB/ # eslint installed here

The prompts only ask to use the global eslint installation, or asks to use one of projectA/projectB's eslint for the whole workspace. It doesn't ask to use A's eslint to lint A, and B's eslint to lint B. is this possible?

EDIT: This extension needs to stop prompting so much. I keep clicking "cancel" because I don't want one project's eslint to override all the other project eslints. I have 10+ projects in my workspace, I'm getting 10 prompts every 10 minutes.

EDIT2: Looks like this setting does what I want, but I'm still getting prompts

{
    "eslint.workingDirectories": [
        { "mode": "auto" }
    ],
}

Will be merged in soon.

Appreciate it. I use vscode-eslint constantly and it makes my job easier. Thank you and all the other contributors for the hard work they do.

I was really hoping to see a release tag or PR that I could diff to understand the changes and more easily scrutinize security. I think what I can do in the meantime is to try and diff the extension as installed right now with the repo.

Please add an option to disable the prompts. Adding them is a significant change that I would not have expected on a patch release. And there is no mention in the release notes of an option allowing us to disable the prompts to restore the old behavior.

image

@tjohnsonBCM please see the discussions here on why that got added: https://github.com/microsoft/vscode-eslint/issues/1012#issuecomment-659097449

I have merged the changes into the release/2.1.x branch in this repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Jamesernator picture Jamesernator  路  5Comments

jasonwilliams picture jasonwilliams  路  6Comments

LinusU picture LinusU  路  7Comments

greggman picture greggman  路  7Comments

julian-sb1 picture julian-sb1  路  6Comments