Vscode-eslint: Git window: "Error: Path must be a string. Received undefined"

[brianegan]

As a user, when I have ESLint installed, and I modify a JS file, and I navigate to the Git window, and I select a JS file, I see the following error:

"Path must be a string. Received undefined"

Screenshot:

[dbaeumer]

@brianegan I can't reproduce this using the latest version of ESLint. Which version of ESLint are you using? Node changed the path API to throw if args aren't strings and this requires to uses the latest version of the ESLint module.

[icetbr]

I can confirm the error in "eslint": "^1.10.3". Fixed in "eslint": "3.12.2".

[dbaeumer]

@brianegan objection to close the issue?

[jthomas1]

I am getting this same error with eslint v3.16.0 so maybe they broke it again?

[jungchris]

@dbaeumer I disabled ESLint 1.2.6 and issue doesn't appear on VS Code Insiders (v1.10.0-insider)

[jiqiangbing]

I am getting this same error and I disabled eslint plugin then error does't appear.

[dbaeumer]

@jiqiangbing, @jungchris which version of the eslint npm package are you using?

[dbaeumer]

I tried this again today and I can't reproduce this. Can someone share a GitHub repository that I can clone that reveals the problem?

[jiqiangbing]

@dbaeumer v3.16.1. And when I click a js file in the SCM panel could probably cause this problem (see the screenshot above). But I also encounter such problem in the explorer panel when I use eslint plugin in a big project.
the .eslintrc is https://gist.github.com/jiqiangbing/cdfd7f8c51487c66e9998cf7857106f6

[jthomas1]

I am on ubuntu 16.04, eslint v3.16.0, node 6.9.2

[dbaeumer]

OK. I fixed the problem with the git index file by not validating them. However I would be interested in a reproducible case for seeing this when opeing a file from the explorer. @jiqiangbing could you provide such a case.

[jiqiangbing]

I got it, my project's package.json had "eslint": "^1.10.3". When I upgrade it to 3.16.1, problem sloved which encountered in explorer.

[dbaeumer]

@jiqiangbing cool. I will close the issue then.

[painotpi]

Still face this issue for

eslint 3.16.1
vscode 1.10.2
npm 4.0.5
node 7.4.0

[dbaeumer]

@ta-run can you share your project so that I can investigate.

[erlethor]

I have the same problem every time I open the Git Diff window. Is there a way to exclude git diffs from the validation?

[pgraci]

^ i am having the same problem as @erlethor. i get this error every time I open the Diff window, on any project I am working on.

[dbaeumer]

@erlethor @pgraci published 1.2.8 today which should disable all validation of git diff windows.

[painotpi]

@dbaeumer can't share the project as it's a corporate one.
But error's gone after today's update. Thanks :)

[erlethor]

Thanks for the quick fix! It worked well.