Vscode-docker: WORKDIR paths should be absolute

Created on 14 Dec 2019  路  13Comments  路  Source: microsoft/vscode-docker

  1. F1 > Docker: Add Docker Files to Workspace
  2. ASP鈥ET Core

The generated Dockerfile has an error on WORKDIR "/src/.". See below:

image

I have to remove double quote manually to remove the warning.

image

Is this kind of bug in vscode-docker?

P2 external fix released

Most helpful comment

@doggy8088 This is an issue with the linter where it isn't taking the quotation marks into account correctly. I have opened rcjsuen/dockerfile-utils#67 to track this.

Thank you for your bug report and have a great day!

All 13 comments

@doggy8088 This is an issue with the linter where it isn't taking the quotation marks into account correctly. I have opened rcjsuen/dockerfile-utils#67 to track this.

Thank you for your bug report and have a great day!

@rcjsuen Thanks!

@bwateratmsft You'll need a new version of the language server to get the fix. When are you planning to cut a new release?

The powers that be tell me sometime in the next couple weeks. @BigMorty to keep me honest.

We are actually planning a small release fairly soon, how soon could we integrate a new version of the language server with this fix? Otherwise the next release will be a number weeks out; we don't have a specific date at this time.

@BigMorty The size of the pull request is often rather miniscule (as the change is really a simple change to the package.json file). Let me tie up some loose ends and then I'll push out a new release for you.

@bwateratmsft @BigMorty Opened #1619 to upgrade the language server.

Verified this is fixed.

@bwateratmsft, I assume we will integrate the new language server in our next major release?

@BigMorty Yep!

The fix for this is now available in Docker extension version 1.0.0.

Was this page helpful?
0 / 5 - 0 ratings